Numeric cli arguments should treat 0 as a real value

Author: canova

profile-query-cli/src/index.ts

@@ -335,13 +335,13 @@ async function main(): Promise<void> {
         let functionFilters: FunctionFilterOptions | undefined;
 
         if (subcommand === 'markers') {
-          const hasSearch = !!argv.search;
-          const hasMinDuration = !!argv['min-duration'];
-          const hasMaxDuration = !!argv['max-duration'];
-          const hasCategory = !!argv.category;
+          const hasSearch = argv.search !== undefined;
+          const hasMinDuration = argv['min-duration'] !== undefined;
+          const hasMaxDuration = argv['max-duration'] !== undefined;
+          const hasCategory = argv.category !== undefined;
           const hasStack = argv['has-stack'];
-          const hasLimit = !!argv.limit;
-          const hasGroupBy = !!argv['group-by'];
+          const hasLimit = argv.limit !== undefined;
+          const hasGroupBy = argv['group-by'] !== undefined;
           const hasAutoGroup = argv['auto-group'];
 
           if (
@@ -403,9 +403,9 @@ async function main(): Promise<void> {
 
         // Parse function filter options if this is a functions command
         if (subcommand === 'functions') {
-          const hasSearch = !!argv.search;
-          const hasMinSelf = !!argv['min-self'];
-          const hasLimit = !!argv.limit;
+          const hasSearch = argv.search !== undefined;
+          const hasMinSelf = argv['min-self'] !== undefined;
+          const hasLimit = argv.limit !== undefined;
 
           if (hasSearch || hasMinSelf || hasLimit) {
             functionFilters = {};
@@ -439,8 +439,8 @@ async function main(): Promise<void> {
           subcommand === 'samples-top-down' ||
           subcommand === 'samples-bottom-up'
         ) {
-          const hasMaxLines = !!argv['max-lines'];
-          const hasScoring = !!argv.scoring;
+          const hasMaxLines = argv['max-lines'] !== undefined;
+          const hasScoring = argv.scoring !== undefined;
 
           if (hasMaxLines || hasScoring) {
             callTreeOptions = {};

profile-query-cli/src/test/integration/basic.test.ts

@@ -94,6 +94,57 @@ describe('pq basic functionality', () => {
     expect(result2.stdout).toEqual(result1.stdout);
   });
 
+  test('numeric zero marker filters are preserved instead of being ignored', async () => {
+    await pq(ctx, ['load', 'src/test/fixtures/upgrades/processed-1.json']);
+
+    const minDurationResult = await pq(ctx, [
+      'thread',
+      'markers',
+      '--json',
+      '--min-duration',
+      '0',
+    ]);
+    expect(minDurationResult.stdout).toContain('"minDuration": 0');
+
+    const maxDurationResult = await pq(ctx, [
+      'thread',
+      'markers',
+      '--json',
+      '--max-duration',
+      '0',
+    ]);
+    expect(maxDurationResult.stdout).toContain('"maxDuration": 0');
+  });
+
+  test('numeric zero function filters are preserved instead of being ignored', async () => {
+    await pq(ctx, ['load', 'src/test/fixtures/upgrades/processed-1.json']);
+
+    const result = await pq(ctx, [
+      'thread',
+      'functions',
+      '--json',
+      '--min-self',
+      '0',
+    ]);
+
+    expect(result.stdout).toContain('"minSelf": 0');
+  });
+
+  test('max-lines=0 is rejected instead of silently falling back to the default', async () => {
+    await pq(ctx, ['load', 'src/test/fixtures/upgrades/processed-1.json']);
+
+    const result = await pqFail(ctx, [
+      'thread',
+      'samples-top-down',
+      '--max-lines',
+      '0',
+    ]);
+
+    expect(result.exitCode).not.toBe(0);
+    const output = String(result.stdout || '') + String(result.stderr || '');
+    expect(output).toContain('--max-lines must be a positive integer');
+  });
+
   test('build hash mismatch stops the daemon before cleaning up the session', async () => {
     const loadResult = await pq(ctx, [
       'load',