Merge pull request #1861 from pbenes/pb-remove-heroku-pr-examples

RELATED: FET-1133 Remove heroku demo support for pull-requests

Reviewed-by: Dan Homola
             https://github.com/no23reason

Author: gdgate

.github/pull_request_template.md

@@ -13,7 +13,6 @@ Supported PR commands:
 
 Command | Description
 --- | ---
-`extended test - examples` | Live examples tests
 `extended test - storybook` | Storybook screenshot tests
 
 See more [options](https://confluence.intgdc.com/display/kbhr/How+to+work+with+git+and+Github#HowtoworkwithgitandGithub-Extendedchecks).
@@ -24,13 +23,13 @@ See more [options](https://confluence.intgdc.com/display/kbhr/How+to+work+with+g
 - [ ] [Verify pull-request formalities](https://confluence.intgdc.com/display/Development/Code-reviews)
 - [ ] Change was tested by using [gdc-dev-release](https://confluence.intgdc.com/display/~tomas.vojtasek/Private+NPM) in [gdc-analytical-designer](https://github.com/gooddata/gdc-analytical-designer) and [gdc-dashboards](https://github.com/gooddata/gdc-dashboards) (if applicable)
 - [ ] Migration guide (for major changes) is mentioned in [CHANGELOG.md](../blob/master/CHANGELOG.md).
-- [ ] Successful `extended test - examples`
+- [ ] Run examples locally and run testcafe for local run (no heroku build from pull-request support anymore)
 - [ ] Successful `extended test - storybook`
 - [ ] Checked yarn.lock consistency (no dep. duplicities especially Goodstrap)
 
 
 # Related PRs
-<!-- Mandatory 
+<!-- Mandatory
 
 Example:
 - gdc-analytical-designer: https://github.com/gooddata/gdc-analytical-designer/pull/2072

Procfile

@@ -5,7 +5,6 @@
 
 ## Getting started
 - [GoodData.UI Documentation](http://sdk.gooddata.com/gooddata-ui/)
-- [GoodData.UI Live Examples](https://gooddata-examples.herokuapp.com/)
 - [Stack Overflow](https://stackoverflow.com/questions/tagged/gooddata)
 
 ### Usage
@@ -52,18 +51,6 @@ These commands may come in handy while developing:
 | `yarn examples-server` | serve built Live Examples - see `/examples/server/src` |
 | `yarn examples-testcafe` | run testcafe tests against `localhost:8999` |
 
-### Deploy to heroku.com
-When you deploy this repo to heroku, it serves *GoodData.UI Live Examples*.
-Relevant tasks are in `Procfile` and `package.json`.
-
-```bash
-# run in the project directory
-heroku login
-heroku create <your-app-name>
-heroku config:set DOMAIN_ADMIN_USERNAME=x@gooddata.com DOMAIN_ADMIN_PASSWORD=xy PROJECT_ID_TO_ASSIGN=xms7ga4tf3g3nzucd8380o2bev8oeknp
-git push heroku HEAD:master
-heroku open
-```
 ### Enable Geo Chart for Storybook and Live Examples
 Geo chart uses Mapbox to render map which requires a Mapbox access token.
 - Register an account and create Mapbox access token at [guide](https://docs.mapbox.com/help/how-mapbox-works/access-tokens/)
@@ -81,7 +68,13 @@ cd  <repository-folder>
 yarn install --pure-lockfile
 yarn examples
 ```
-Then open https://localhost:8999 and login using Live Examples account (you can [create one here](https://gooddata-examples.herokuapp.com/registration)).
+Then open https://localhost:8999
+
+### Run testcafe against locally running examples
+Make sure the examples are running locally (previous step)
+```bash
+yarn examples-testcafe
+```
 
 ### Run Storybook locally
 - Run storybook with token stored in `.env` for more secure

README.md

@@ -13,17 +13,3 @@ rpm-build:
 test-storybook:
   - export STORYBOOK_MAPBOX_ACCESS_TOKEN="$MAPBOX_TOKEN"
   - yarn test-storybook
-
-# Mandatory env params:
-# - HEROKU_API_KEY
-# - PULL_REQUEST_ID
-# - LIVE_EXAMPLES_ADMIN_PASSWORD
-# - LIVE_EXAMPLES_TESTER_PASSWORD
-#
-# These are injected at https://github.com/zbycz/ci-infra/blob/cacd3/jenkins/jobs/templates/client-macros.yaml#L73
-examples-deploy-and-testcafe:
-  - bash scripts/ci-deploy-and-testcafe.sh
-
-examples-heroku-destroy:
-  - export HEROKU_APP_NAME="gdc-live-examples-$PULL_REQUEST_ID"
-  - heroku apps:destroy --app=$HEROKU_APP_NAME --confirm $HEROKU_APP_NAME