Skip to content

Commit 3d578db

Browse files
author
gdgate
authored
Merge pull request #1772 from gooddata/develop
Merge develop to master Reviewed-by: https://github.com/sangtm
2 parents 3de9137 + c5f6c8b commit 3d578db

3 files changed

Lines changed: 12 additions & 37 deletions

File tree

.travis.yml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ stages:
77
if: type IN (api, cron)
88
- name: platform-cleanup
99
if: type IN (cron)
10-
- name: license-update
11-
if: branch = master AND type = push
1210
- name: gem-release
1311
if: branch = master AND type = push
1412
- name: gem-smoke-test
@@ -348,16 +346,6 @@ jobs:
348346
rvm: jruby-9.1.14
349347
osx_image: xcode9.4
350348

351-
- stage: license-update
352-
name: Update license file
353-
rvm: 2.3
354-
script: |
355-
bundle exec rake license:update
356-
- stage: license-update
357-
name: Update license file
358-
rvm: jruby-9.1.14
359-
script: |
360-
bundle exec rake license:update
361349
- stage: gem-release
362350
name: deploy MRI gem
363351
rvm: 2.3

Rakefile

Lines changed: 7 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,14 @@ namespace :gem do
3333
desc "Release gem version #{GoodData::VERSION} to rubygems"
3434
task :release do
3535
gem = "gooddata-#{GoodData::VERSION}.gem"
36+
origin_license_file = 'LICENSE'
37+
new_license_file = 'LICENSE_FOR_RUBY_SDK_COMPONENT.txt'
3638
notices_file = 'NOTICES.txt'
37-
38-
if File.exist?(notices_file)
39-
File.delete(notices_file)
40-
puts "Deleted files: #{notices_file}"
41-
end
42-
39+
File.delete(origin_license_file) if File.exist?(origin_license_file)
40+
File.delete(notices_file) if File.exist?(notices_file)
41+
puts "Deleted files: #{origin_license_file} and #{notices_file}"
42+
File.rename(new_license_file, origin_license_file) if File.exists?(new_license_file)
43+
puts "Renamed file #{new_license_file} to #{origin_license_file}"
4344
puts "Building #{gem} ..."
4445
res = `gem build ./gooddata.gemspec`
4546
file = res.match('File: (.*)')[1]
@@ -111,24 +112,6 @@ namespace :license do
111112
puts 'All licenses seem to be OK'
112113
end
113114

114-
desc 'Update LICENSE file'
115-
task :update do
116-
origin_license_file = 'LICENSE'
117-
new_license_file = 'LICENSE_FOR_RUBY_SDK_COMPONENT.txt'
118-
119-
if File.exist?(origin_license_file)
120-
File.delete(origin_license_file)
121-
puts "Deleted files: #{origin_license_file}"
122-
end
123-
124-
if File.exists?(new_license_file)
125-
File.rename(new_license_file, origin_license_file)
126-
puts "Renamed file #{new_license_file} to #{origin_license_file}"
127-
end
128-
129-
puts 'Update LICENSE seem to be OK'
130-
end
131-
132115
desc 'Add license header to each file'
133116
task :add do
134117
spec = Gem::Specification.load('gooddata.gemspec')

gooddata.gemspec

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,11 @@ Gem::Specification.new do |s|
6161
end
6262

6363
s.add_dependency 'aws-sdk-s3', '~> 1.16'
64-
s.add_dependency 'docile', '~> 1.1'
64+
if RUBY_VERSION >= '2.5'
65+
s.add_dependency 'docile', '~> 1.1'
66+
else
67+
s.add_dependency 'docile', '> 1.1', '< 1.4.0'
68+
end
6569
s.add_dependency 'gli', '~> 2.15'
6670
s.add_dependency 'gooddata_datawarehouse', '~> 0.0.10' if RUBY_PLATFORM == 'java'
6771
s.add_dependency 'highline', '= 2.0.0.pre.develop.14'

0 commit comments

Comments
 (0)