Skip to content

Commit 58525bd

Browse files
vvermanvverman
committed
Lint fixes.
1 parent c65c290 commit 58525bd

13 files changed

Lines changed: 346 additions & 341 deletions

‎google-auth-library-java/oauth2_http/java/com/google/auth/oauth2/GoogleCredentials.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -373,8 +373,7 @@ final RegionalAccessBoundary getRegionalAccessBoundary() {
373373
*/
374374
void refreshRegionalAccessBoundaryIfExpired(@Nullable URI uri, @Nullable AccessToken token)
375375
throws IOException {
376-
if (!(this instanceof RegionalAccessBoundaryProvider)
377-
|| !isDefaultUniverseDomain()) {
376+
if (!(this instanceof RegionalAccessBoundaryProvider) || !isDefaultUniverseDomain()) {
378377
return;
379378
}
380379

‎google-auth-library-java/oauth2_http/java/com/google/auth/oauth2/RegionalAccessBoundary.java‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,7 @@
4444
import com.google.api.client.util.Clock;
4545
import com.google.api.client.util.ExponentialBackOff;
4646
import com.google.api.client.util.Key;
47-
import com.google.api.core.InternalApi;
4847
import com.google.auth.http.HttpTransportFactory;
49-
import com.google.common.annotations.VisibleForTesting;
5048
import com.google.common.base.MoreObjects;
5149
import com.google.common.base.Preconditions;
5250
import java.io.IOException;
@@ -174,7 +172,6 @@ public String toString() {
174172
* @return True if the regional access boundary feature is enabled, false otherwise.
175173
*/
176174

177-
178175
/**
179176
* Refreshes the regional access boundary by making a network call to the lookup endpoint.
180177
*

‎google-auth-library-java/oauth2_http/java/com/google/auth/oauth2/RegionalAccessBoundaryManager.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,12 @@ final class RegionalAccessBoundaryManager {
8888
// on concurrent refresh tasks, while threadCount provides unique names
8989
// for easier debugging.
9090
private static final AtomicInteger threadCount = new AtomicInteger(0);
91-
91+
9292
// Bounded executor service ensures hard limits on concurrent refresh tasks and queued tasks
9393
// to avoid resource exhaustion.
9494
private static final int EXECUTOR_POOL_SIZE = 5;
9595
private static final int EXECUTOR_QUEUE_CAPACITY = 100;
96-
96+
9797
private static final ExecutorService EXECUTOR;
9898

9999
static {

‎google-auth-library-java/oauth2_http/javatests/com/google/auth/oauth2/AwsCredentialsTest.java‎

Lines changed: 70 additions & 70 deletions
Large diffs are not rendered by default.

‎google-auth-library-java/oauth2_http/javatests/com/google/auth/oauth2/ComputeEngineCredentialsTest.java‎

Lines changed: 60 additions & 60 deletions
Large diffs are not rendered by default.

‎google-auth-library-java/oauth2_http/javatests/com/google/auth/oauth2/ExternalAccountAuthorizedUserCredentialsTest.java‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -707,8 +707,8 @@ void getRequestMetadata() throws IOException {
707707
GoogleCredentials credentials =
708708
ExternalAccountAuthorizedUserCredentials.fromJson(buildJsonCredentials(), transportFactory);
709709
credentials.regionalAccessBoundaryManager.setCachedRAB(
710-
new RegionalAccessBoundary("dummy-locations", Arrays.asList("dummy-loc"), credentials.clock)
711-
);
710+
new RegionalAccessBoundary(
711+
"dummy-locations", Arrays.asList("dummy-loc"), credentials.clock));
712712

713713
Map<String, List<String>> metadata = credentials.getRequestMetadata(CALL_URI);
714714

@@ -721,8 +721,8 @@ void getRequestMetadata_withQuotaProjectId() throws IOException {
721721
GoogleCredentials credentials =
722722
ExternalAccountAuthorizedUserCredentials.fromJson(buildJsonCredentials(), transportFactory);
723723
credentials.regionalAccessBoundaryManager.setCachedRAB(
724-
new RegionalAccessBoundary("dummy-locations", Arrays.asList("dummy-loc"), credentials.clock)
725-
);
724+
new RegionalAccessBoundary(
725+
"dummy-locations", Arrays.asList("dummy-loc"), credentials.clock));
726726

727727
Map<String, List<String>> metadata = credentials.getRequestMetadata(CALL_URI);
728728

@@ -742,8 +742,8 @@ void getRequestMetadata_withAccessToken() throws IOException {
742742
.setAccessToken(new AccessToken(ACCESS_TOKEN, /* expirationTime= */ null))
743743
.build();
744744
credentials.regionalAccessBoundaryManager.setCachedRAB(
745-
new RegionalAccessBoundary("dummy-locations", Arrays.asList("dummy-loc"), credentials.clock)
746-
);
745+
new RegionalAccessBoundary(
746+
"dummy-locations", Arrays.asList("dummy-loc"), credentials.clock));
747747

748748
Map<String, List<String>> metadata = credentials.getRequestMetadata(CALL_URI);
749749

‎google-auth-library-java/oauth2_http/javatests/com/google/auth/oauth2/ExternalAccountCredentialsTest.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,8 +1109,8 @@ void getRequestMetadata_withQuotaProjectId() throws IOException {
11091109
.setQuotaProjectId("quotaProjectId")
11101110
.build();
11111111
testCredentials.regionalAccessBoundaryManager.setCachedRAB(
1112-
new RegionalAccessBoundary("dummy-locations", Arrays.asList("dummy-loc"), testCredentials.clock)
1113-
);
1112+
new RegionalAccessBoundary(
1113+
"dummy-locations", Arrays.asList("dummy-loc"), testCredentials.clock));
11141114

11151115
Map<String, List<String>> requestMetadata =
11161116
testCredentials.getRequestMetadata(URI.create("http://googleapis.com/foo/bar"));

‎google-auth-library-java/oauth2_http/javatests/com/google/auth/oauth2/IdTokenCredentialsTest.java‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ void hashCode_equals() throws IOException {
4848
ComputeEngineCredentials credentials =
4949
ComputeEngineCredentials.newBuilder().setHttpTransportFactory(transportFactory).build();
5050
credentials.regionalAccessBoundaryManager.setCachedRAB(
51-
new RegionalAccessBoundary("dummy-locations", Arrays.asList("dummy-loc"), credentials.clock)
52-
);
51+
new RegionalAccessBoundary(
52+
"dummy-locations", Arrays.asList("dummy-loc"), credentials.clock));
5353

5454
String targetAudience = "https://foo.bar";
5555
IdTokenCredentials tokenCredential =
@@ -77,8 +77,8 @@ void toString_equals() throws IOException {
7777
ComputeEngineCredentials credentials =
7878
ComputeEngineCredentials.newBuilder().setHttpTransportFactory(transportFactory).build();
7979
credentials.regionalAccessBoundaryManager.setCachedRAB(
80-
new RegionalAccessBoundary("dummy-locations", Arrays.asList("dummy-loc"), credentials.clock)
81-
);
80+
new RegionalAccessBoundary(
81+
"dummy-locations", Arrays.asList("dummy-loc"), credentials.clock));
8282

8383
String targetAudience = "https://foo.bar";
8484
IdTokenCredentials tokenCredential =
@@ -107,8 +107,8 @@ void serialize() throws IOException, ClassNotFoundException {
107107
ComputeEngineCredentials credentials =
108108
ComputeEngineCredentials.newBuilder().setHttpTransportFactory(transportFactory).build();
109109
credentials.regionalAccessBoundaryManager.setCachedRAB(
110-
new RegionalAccessBoundary("dummy-locations", Arrays.asList("dummy-loc"), credentials.clock)
111-
);
110+
new RegionalAccessBoundary(
111+
"dummy-locations", Arrays.asList("dummy-loc"), credentials.clock));
112112

113113
String targetAudience = "https://foo.bar";
114114
IdTokenCredentials tokenCredential =

0 commit comments

Comments
 (0)