Skip to content

Commit 7638bb7

Browse files
committed
chore: Add comment to explain the CHANNEL_POOL_MAX_RPCS_PER_CHANNEL constant
1 parent 11346a3 commit 7638bb7

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

java-datastore/google-cloud-datastore/src/main/java/com/google/cloud/datastore/DatastoreOptions.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,10 @@ public class DatastoreOptions extends ServiceOptions<Datastore, DatastoreOptions
5757
public static final String LOCAL_HOST_ENV_VAR = "DATASTORE_EMULATOR_HOST";
5858
public static final int INIT_CHANNEL_COUNT = 5;
5959
static final int CHANNEL_POOL_DEFAULT_RESIZE_DELTA = 5;
60+
61+
// Configure this default to be 100 to match the typical default `MAX_CONCURRENT_STREAMS`.
62+
// Larger values *may* experience possible client-side queueing as excess streams cannot be
63+
// multiplexed onto a full Http2 connection.
6064
static final int CHANNEL_POOL_MAX_RPCS_PER_CHANNEL = 100;
6165
public static final int MIN_CHANNEL_COUNT = 1;
6266

0 commit comments

Comments
 (0)