add --auto-allocation-max-batch-size indexer-agent option (#1177)

Signed-off-by: Tomás Migone <tomas@edgeandnode.com>
Co-authored-by: Nate Gentile <nate.gentile@kraken.com>

Author: tmigone

packages/indexer-agent/README.md

@@ -50,6 +50,13 @@ Indexer Infrastructure
                                     inside a batch for auto allocation
                                     management. No obvious upperbound, with
                                     default of 1           [number] [default: 1]
+  --auto-allocation-max-batch-size  Maximum number of allocation transactions
+                                    inside a batch for auto allocation
+                                    management. Limits the number of actions
+                                    processed per batch to prevent multicall
+                                    failures when there are many allocations.
+                                    Remaining actions will be processed in
+                                    subsequent batches.                [number]
 
 Postgres
   --postgres-host        Postgres host                       [string] [required]

packages/indexer-agent/src/commands/start.ts

@@ -348,6 +348,12 @@ export const start = {
         default: 1,
         group: 'Indexer Infrastructure',
       })
+      .option('auto-allocation-max-batch-size', {
+        description: `Maximum number of allocation transactions inside a batch for auto allocation management. Limits the number of actions processed per batch to prevent multicall failures when there are many allocations. Remaining actions will be processed in subsequent batches.`,
+        type: 'number',
+        required: false,
+        group: 'Indexer Infrastructure',
+      })
       .check(argv => {
         if (
           !argv['network-subgraph-endpoint'] &&
@@ -408,6 +414,7 @@ export async function createNetworkSpecification(
     voucherRedemptionMaxBatchSize: argv.voucherRedemptionMaxBatchSize,
     allocationManagementMode: argv.allocationManagement,
     autoAllocationMinBatchSize: argv.autoAllocationMinBatchSize,
+    autoAllocationMaxBatchSize: argv.autoAllocationMaxBatchSize,
     allocateOnNetworkSubgraph: argv.allocateOnNetworkSubgraph,
     register: argv.register,
     maxProvisionInitialSize: argv.maxProvisionInitialSize,

packages/indexer-common/src/indexer-management/actions.ts

@@ -323,7 +323,10 @@ export class ActionManager {
                 status: [ActionStatus.APPROVED, ActionStatus.DEPLOYING],
                 protocolNetwork,
               },
-              order: [['priority', 'ASC']],
+              order: [
+                ['priority', 'ASC'],
+                ['id', 'ASC'],
+              ],
               transaction,
               lock: transaction.LOCK.UPDATE,
             })
@@ -355,13 +358,29 @@ export class ActionManager {
           logger.error('Failed to query approved actions for network', { error })
           return []
         }
-        // mark all approved actions as DEPLOYING, this serves as a lock on other processing of them
-        await this.markActions(
-          approvedAndDeployingActions,
-          transaction,
-          ActionStatus.DEPLOYING,
-        )
-        return approvedAndDeployingActions
+
+        // Limit batch size to prevent multicall failures when there are many allocations
+        const maxBatchSize =
+          network.specification.indexerOptions.autoAllocationMaxBatchSize
+        let actionsToExecute = approvedAndDeployingActions
+        if (maxBatchSize && approvedAndDeployingActions.length > maxBatchSize) {
+          actionsToExecute = approvedAndDeployingActions.slice(0, maxBatchSize)
+          logger.info(
+            `Limiting batch size to ${maxBatchSize} actions (${approvedAndDeployingActions.length} total approved). ` +
+              `Remaining ${
+                approvedAndDeployingActions.length - maxBatchSize
+              } actions will be processed in subsequent batches.`,
+            {
+              totalApproved: approvedAndDeployingActions.length,
+              maxBatchSize,
+              actionsInThisBatch: actionsToExecute.length,
+            },
+          )
+        }
+
+        // mark actions to execute as DEPLOYING, this serves as a lock on other processing of them
+        await this.markActions(actionsToExecute, transaction, ActionStatus.DEPLOYING)
+        return actionsToExecute
       },
     )
 

packages/indexer-common/src/network-specification.ts

@@ -61,6 +61,7 @@ export const IndexerOptions = z
       .default('auto')
       .transform((x) => x as AllocationManagementMode),
     autoAllocationMinBatchSize: positiveNumber().default(1),
+    autoAllocationMaxBatchSize: positiveNumber().optional(),
     allocateOnNetworkSubgraph: z.boolean().default(false),
     register: z.boolean().default(true),
     maxProvisionInitialSize: GRT()