Version Packages (alpha)#4239
Closed
acao wants to merge 1 commit into
Closed
Conversation
592aacf to
229c7fd
Compare
Contributor
|
The latest changes of this PR are not available as canary, since there are no linked |
This was referenced May 9, 2026
trevor-scheer
added a commit
that referenced
this pull request
May 9, 2026
## Summary Three stacked bugs have made `yarn license-check` a near-no-op, and the alpha-release PR (#4239) recently surfaced one of them: 1. **`jsgl --local packages/*` was only ever checking one package.** The shell expands the glob, but `--local` is a `string` flag, so only the first arg (`packages/cm6-graphql`) is honored — every other workspace package is silently ignored. Switched to `jsgl --local .` so `js-green-licenses` walks the root + every `packages/*/package.json` itself, and registers them all as local. 2. **`js-green-licenses` has a regex bug** at `checker.js:232`: ```js const version = versionSpec.replace(/^[^~]/, ''); // [^~] = "not tilde" ``` It's meant to strip a leading `^` so the local-package short-circuit at line 234 can match, but `[^~]` matches any first non-tilde char — so a pinned `5.5.1-alpha.0` becomes `.5.1-alpha.0` and the lookup misses. Patched via `patch-package`: `/^[^~]/` → `/^[~^]/`. This is the same fix as the (forever-unmerged) upstream PR [google/js-green-licenses#230](google/js-green-licenses#230). 3. **Seven previously-hidden findings surface** once `--local .` actually walks the tree — all permissive in practice. Allowlisted them in `js-green-licenses.json`: - `BlueOak-1.0.0` (permissive, but not in jsgl's default green list): `glob`, `minimatch`, `minipass`, `path-scurry`, `lru-cache` - non-SPDX-in-manifest MIT: `spawn-command`, `spawndamnit` Without this, alpha release PRs (and eventually any main release that bumps a cross-workspace dep) fail `Check Licenses` because the bumped workspace deps aren't on npm yet and the local-skip was misfiring. `google/js-green-licenses` is archived, so a follow-up to replace it with a maintained tool will land separately. ## Test plan - [x] Reproduced the original `VersionNotFoundError` locally on `changeset-release/graphiql-6` HEAD - [x] After the fix, `yarn license-check` exits 0 on both `changeset-release/graphiql-6` (alpha state, includes `graphql-language-service@5.5.1-alpha.0`) and `main` - [x] `yarn format-check` passes - [ ] CI green
229c7fd to
544a2d1
Compare
544a2d1 to
5caf875
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to graphiql-6, this PR will be updated.
graphiql-6is currently in pre mode so this branch has prereleases rather than normal releases. If you want to exit prereleases, runchangeset pre exitongraphiql-6.Releases
graphiql@6.0.0-alpha.0
Major Changes
58de626Thanks @trevor-scheer! - Initial v6 alpha. Refs GraphiQL Modernization #4219.Patch Changes
#4181
f1a210eThanks @trevor-scheer! - Fix schema prop to skip introspection when IntrospectionQuery data is providedPreviously, passing an
IntrospectionQueryresult as theschemaprop would still trigger a network introspection request. TheshouldIntrospectcheck only recognizedGraphQLSchemainstances (viaisSchema), not raw introspection data. Now, when anIntrospectionQueryis passed, a schema is built from it directly usingbuildClientSchemaand introspection is skipped.#4211
e7b30c1Thanks @davidjb! - Add *.css to sideEffects to allow import of CSS in Webpack JavascriptUpdated dependencies [
f1a210e,6f5d5d2,40359eb,72e8970,e7b30c1]:@graphiql/react@0.38.0-alpha.0
Minor Changes
72e8970Thanks @trevor-scheer! - Introduce the v6 OKLCH design-token system with both dark and light theme palettes. Tokens (--bg-canvas,--fg-default,--accent-blue, etc.) are stored as OKLCH triplets so opacity can be combined at the call site. Themes are keyed offdata-theme(darkis the default;lightactivates explicitly or viaprefers-color-scheme: lightwhen no override is set). Existing v5 variables are unchanged; component styles continue to use them until they are migrated.Patch Changes
#4181
f1a210eThanks @trevor-scheer! - Fix schema prop to skip introspection when IntrospectionQuery data is providedPreviously, passing an
IntrospectionQueryresult as theschemaprop would still trigger a network introspection request. TheshouldIntrospectcheck only recognizedGraphQLSchemainstances (viaisSchema), not raw introspection data. Now, when anIntrospectionQueryis passed, a schema is built from it directly usingbuildClientSchemaand introspection is skipped.#4140
40359ebThanks @trevor-scheer! - Removereact-compiler-runtimepeer dependency#4211
e7b30c1Thanks @davidjb! - Add *.css to sideEffects to allow import of CSS in Webpack JavascriptUpdated dependencies [
914a547,463df14,4bb7909,10f66d5]:@graphiql/toolkit@0.12.0-alpha.0
Minor Changes
463df14Thanks @trevor-scheer! - Send spec-compliantAcceptheader (application/graphql-response+json) increateSimpleFetchercm6-graphql@0.2.2-alpha.0
Patch Changes
914a547,10f66d5]:codemirror-graphql@2.2.5-alpha.0
Patch Changes
914a547,10f66d5]:@graphiql/plugin-code-exporter@5.1.2-alpha.0
Patch Changes
#4211
e7b30c1Thanks @davidjb! - Add *.css to sideEffects to allow import of CSS in Webpack JavascriptUpdated dependencies [
f1a210e,40359eb,72e8970,e7b30c1]:@graphiql/plugin-doc-explorer@0.4.2-alpha.0
Patch Changes
#4231
6f5d5d2Thanks @trevor-scheer! - Fix degraded type declarations in published packagesBoth packages import from
@graphiql/reactat build time but only declared it as a peer dependency. Yarn workspaces topologically orders builds viadependencies/devDependencies, notpeerDependencies, so on a clean checkout these plugins built before@graphiql/reacthad emitted itsdist/*.d.ts.vite-plugin-dtsthen rantscagainst unresolved@graphiql/reactimports, fell back toanyfor any return type that flowed throughuseGraphiQL, and published.d.tsartifacts where hooks likeuseDocExploreranduseDocExplorerActionsresolved to() => anyinstead of their real shapes.Adding
@graphiql/reactas adevDependencymatches the pattern already in@graphiql/plugin-explorerand@graphiql/plugin-code-exporterand lets the build run in topological order.#4140
40359ebThanks @trevor-scheer! - Removereact-compiler-runtimepeer dependency#4211
e7b30c1Thanks @davidjb! - Add *.css to sideEffects to allow import of CSS in Webpack JavascriptUpdated dependencies [
f1a210e,40359eb,72e8970,e7b30c1]:@graphiql/plugin-explorer@5.1.2-alpha.0
Patch Changes
#4211
e7b30c1Thanks @davidjb! - Add *.css to sideEffects to allow import of CSS in Webpack JavascriptUpdated dependencies [
f1a210e,40359eb,72e8970,e7b30c1]:@graphiql/plugin-history@0.4.2-alpha.0
Patch Changes
#4231
6f5d5d2Thanks @trevor-scheer! - Fix degraded type declarations in published packagesBoth packages import from
@graphiql/reactat build time but only declared it as a peer dependency. Yarn workspaces topologically orders builds viadependencies/devDependencies, notpeerDependencies, so on a clean checkout these plugins built before@graphiql/reacthad emitted itsdist/*.d.ts.vite-plugin-dtsthen rantscagainst unresolved@graphiql/reactimports, fell back toanyfor any return type that flowed throughuseGraphiQL, and published.d.tsartifacts where hooks likeuseDocExploreranduseDocExplorerActionsresolved to() => anyinstead of their real shapes.Adding
@graphiql/reactas adevDependencymatches the pattern already in@graphiql/plugin-explorerand@graphiql/plugin-code-exporterand lets the build run in topological order.#4140
40359ebThanks @trevor-scheer! - Removereact-compiler-runtimepeer dependency#4211
e7b30c1Thanks @davidjb! - Add *.css to sideEffects to allow import of CSS in Webpack JavascriptUpdated dependencies [
463df14,f1a210e,40359eb,72e8970,e7b30c1]:graphql-language-service@5.5.1-alpha.0
Patch Changes
#3882
914a547Thanks @bensengupta! - Fix off-by-one when hovering over token#4222
10f66d5Thanks @trevor-scheer! - Unpin and update graphql-config dependencygraphql-language-service-cli@3.5.1-alpha.0
Patch Changes
ca83879,914a547,10f66d5]:graphql-language-service-server@2.14.9-alpha.0
Patch Changes
#4187
ca83879Thanks @trevor-scheer! - Bump required TypeScript runtime dependency from^5.3.3to^5.8.0. This is preparatory work for adopting the TypeScript Native Preview (tsgo) compiler in a follow-up change, which tracks TypeScript 5.8 semantics. In practice^5.3.3already resolved to TS 5.8+ for most consumers; the new floor only affects consumers who pin TypeScript to 5.3–5.7 via resolutions or overrides.#4222
10f66d5Thanks @trevor-scheer! - Unpin and update graphql-config dependencyUpdated dependencies [
914a547,10f66d5]:monaco-graphql@1.7.4-alpha.0
Patch Changes
#4225
4bb7909Thanks @trevor-scheer! - Fix hover crashing on the first line of a queryGraphQLWorker.doHoverwas passing 0-indexed positions togetRange, which expects a 1-indexedSourceLocation(per the GraphQL spec). On the first line this causedExpected Parser stream to be availableto be logged and hover to returnnull. On other lines it returned the range of the previous line's last token rather than the token under the cursor. UsegetTokenAtPositionto compute the actual token range instead.Updated dependencies [
914a547,10f66d5]:vscode-graphql@0.13.3-alpha.0
Patch Changes
#4183
2ef9389Thanks @trevor-scheer! - Fix VS Code extension publishing scriptsUpdated dependencies [
ca83879,10f66d5]:vscode-graphql-execution@0.3.3-alpha.0
Patch Changes
#4183
2ef9389Thanks @trevor-scheer! - Fix VS Code extension publishing scripts#4222
10f66d5Thanks @trevor-scheer! - Unpin and update graphql-config dependencyvscode-graphql-syntax@1.3.9-alpha.0
Patch Changes
#4183
2ef9389Thanks @trevor-scheer! - Fix VS Code extension publishing scripts#4143
7979bf5Thanks @Netail! - Add syntax highlighting support for subscription operations.#4144
f7e2a56Thanks @jsmnbom! - Addtext.html.vueas inline injection target.This PR broke tooling by changing the vue grammar scope from
source.vuetotext.html.vue. This addstext.html.vueas an additional injection target for GraphQL syntax highlighting so that it works in both cases.