Feature/php84 compatible (#391)

* fix phpunit options

* fix deprecated warning

* add gitignore coverage/

* refactor ci.yml

Author: dmnlk

.github/workflows/ci.yml

@@ -23,24 +23,19 @@ jobs:
 
 
     steps:
-      - uses: actions/checkout@v3
-
-      - uses: php-actions/composer@v6
-
-      - name: PHPUnit Tests
-        uses: php-actions/phpunit@v4
-        env:
-          XDEBUG_MODE: coverage
-        with:
-          php_extensions: xdebug
-          coverage_html: "coverage/html/"
-          version: 9.5
-          bootstrap: tests/bootstrap.php
-          configuration: phpunit.xml
-          php_version: ${{ matrix.php-versions }}
-
+      -   name: Checkout
+          uses: actions/checkout@v4
+      -   name: Setup PHP
+          uses: shivammathur/setup-php@v2
+          with:
+              php-version: ${{ matrix.php-versions }}     
+              coverage: xdebug
+      -   name: Composer Install
+          run: composer install --classmap-authoritative --no-interaction --no-cache
+      -   name: run tests
+          run: vendor/bin/phpunit --configuration phpunit.xml --bootstrap=tests/bootstrap.php --coverage-html=coverage/html/
       - name: Archive code coverage results
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: code-coverage-report
-          path: coverage/html
+          name: code-coverage-report-${{ matrix.php-versions }}
+          path: coverage/html/

.gitignore

@@ -3,3 +3,4 @@ composer.lock
 clover.xml
 composer.phar
 .idea
+coverage/

phpunit.xml

@@ -1,9 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <phpunit backupGlobals="false"
   backupStaticAttributes="false"
-  failOnDeprecation="true"
-  displayDetailsOnTestsThatTriggerDeprecations="true"
-  displayDetailsOnPhpunitDeprecations="true"
+  convertDeprecationsToExceptions="true"
   verbose="true"
   bootstrap="tests/bootstrap.php">
   <testsuites>

src/PHPSQLParser/processors/AbstractProcessor.php

@@ -64,7 +64,7 @@ abstract class AbstractProcessor {
      *
      * @param Options $options
      */
-    public function __construct(Options $options = null)
+    public function __construct(?Options $options = null)
     {
         $this->options = $options;
     }