Upgrade to phpunit 9 (#350)

* upgrade phpunit to version 9.5

so tests can be run with php 8.1

(the test suite does not run yet, need to adapt some phpunit code,
and address some php deprecations, see following commits)

* phpunit upgrade: adapt test case class name

phpunit's classes are now namespaced

* phpunit upgrade: `setUp` must match its parent's signature

* phpunit upgrade: avoid risky tests label

for tests that do not perform any assertions

* avoid polluting the phpunit output

* phpunit upgrade: `@expectedException` is not available anymore

* php 8.1 deprecation: `preg_split`'s `$limit` param should be an int

* php 8.1 deprecation: Automatic conversion of false to array is deprecated

* php 8.1 deprecation: Automatic conversion of false to array is deprecated

* php 8.1 deprecation: Automatic conversion of false to array is deprecated

* php 8.1 deprecation: Automatic conversion of false to array is deprecated

Author: nicoder

composer.json

@@ -41,7 +41,7 @@
 	},
 	"require-dev" : {
 		"squizlabs/php_codesniffer" : "^1.5.1",
-		"phpunit/phpunit" : "^4.0.14",
+		"phpunit/phpunit" : "^9.5.13",
 		"analog/analog" : "^1.0.6"
 	}
 }

src/PHPSQLParser/lexer/PHPSQLLexer.php

@@ -84,7 +84,7 @@ public function split($sql) {
         if (!is_string($sql)) {
             throw new InvalidParameterException($sql);
         }
-        $tokens = preg_split($this->splitters->getSplittersRegexPattern(), $sql, null, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY);
+        $tokens = preg_split($this->splitters->getSplittersRegexPattern(), $sql, 0, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY);
         $tokens = $this->concatComments($tokens);
         $tokens = $this->concatEscapeSequences($tokens);
         $tokens = $this->balanceBackticks($tokens);

src/PHPSQLParser/processors/FromProcessor.php

@@ -76,14 +76,18 @@ protected function initParseInfo($parseInfo = false) {
         }
         // loop init
         return array('expression' => "", 'token_count' => 0, 'table' => "", 'no_quotes' => "", 'alias' => false,
-                     'hints' => false, 'join_type' => "", 'next_join_type' => "",
+                     'hints' => array(), 'join_type' => "", 'next_join_type' => "",
                      'saved_join_type' => $parseInfo['saved_join_type'], 'ref_type' => false, 'ref_expr' => false,
                      'base_expr' => false, 'sub_tree' => false, 'subquery' => "");
     }
 
     protected function processFromExpression(&$parseInfo) {
         $res = array();
 
+        if ($parseInfo['hints'] === array()) {
+            $parseInfo['hints'] = false;
+        }
+
         // exchange the join types (join_type is save now, saved_join_type holds the next one)
         $parseInfo['join_type'] = $parseInfo['saved_join_type']; // initialized with JOIN
         $parseInfo['saved_join_type'] = ($parseInfo['next_join_type'] ? $parseInfo['next_join_type'] : 'JOIN');

src/PHPSQLParser/processors/IndexProcessor.php

@@ -72,7 +72,7 @@ public function process($tokens) {
 
         $currCategory = 'INDEX_NAME';
         $result = array('base_expr' => false, 'name' => false, 'no_quotes' => false, 'index-type' => false, 'on' => false,
-                        'options' => false);
+                        'options' => array());
         $expr = array();
         $base_expr = '';
         $skip = 0;
@@ -300,6 +300,9 @@ public function process($tokens) {
             $currCategory = '';
         }
 
+        if ($result['options'] === array()) {
+            $result['options'] = false;
+        }
         return $result;
     }
 }

src/PHPSQLParser/processors/SQLProcessor.php

@@ -59,7 +59,7 @@ public function process($tokens) {
         $prev_category = "";
         $token_category = "";
         $skip_next = 0;
-        $out = false;
+        $out = array();
 
 	// $tokens may come as a numeric indexed array starting with an index greater than 0 (or as a boolean)
 	$tokenCount = count($tokens);

src/PHPSQLParser/processors/TableProcessor.php

@@ -83,7 +83,7 @@ public function process($tokens) {
 
         $currCategory = 'TABLE_NAME';
         $result = array('base_expr' => false, 'name' => false, 'no_quotes' => false, 'create-def' => false,
-                        'options' => false, 'like' => false, 'select-option' => false);
+                        'options' => array(), 'like' => false, 'select-option' => false);
         $expr = array();
         $base_expr = '';
         $skip = 0;
@@ -366,6 +366,9 @@ public function process($tokens) {
         if ($result['select-option'] === false) {
             unset($result['select-option']);
         }
+        if ($result['options'] === array()) {
+            $result['options'] = false;
+        }
 
         return $result;
     }

tests/cases/AbstractTestCase.php

@@ -5,7 +5,7 @@
 use PHPSQLParser\PHPSQLCreator;
 use Analog\Analog;
 
-abstract class AbstractTestCase extends \PHPUnit_Framework_TestCase {
+abstract class AbstractTestCase extends \PHPUnit\Framework\TestCase {
 
 	protected $parser;
 	protected $creator;
@@ -22,7 +22,7 @@ protected function logSerialized($message) {
 	 * @before
 	 * Executed before each test
 	 */
-	protected function setup() {
+	protected function setup(): void {
 		$this->parser = new PHPSQLParser();
 		$this->creator = new PHPSQLCreator();
 	}

tests/cases/creator/AlterTest.php

@@ -3,9 +3,8 @@
 
 use PHPSQLParser\PHPSQLParser;
 use PHPSQLParser\PHPSQLCreator;
-use PHPUnit_Framework_TestCase;
 
-class AlterTest extends PHPUnit_Framework_TestCase
+class AlterTest extends \PHPUnit\Framework\TestCase
 {
     public function testAlterChangeColumn()
     {

tests/cases/creator/ascTest.php

@@ -42,7 +42,7 @@
 use PHPSQLParser\PHPSQLParser;
 use PHPSQLParser\PHPSQLCreator;
 
-class ascTest extends \PHPUnit_Framework_TestCase {
+class ascTest extends \PHPUnit\Framework\TestCase {
 
     public function testAsc() {
         $sql = "SELECT qid FROM QUESTIONS WHERE gid='1' and language='de-informal' ORDER BY question_order, title ASC";

tests/cases/creator/count_distinctTest.php

@@ -42,7 +42,7 @@
 use PHPSQLParser\PHPSQLParser;
 use PHPSQLParser\PHPSQLCreator;
 
-class count_distinctTest extends \PHPUnit_Framework_TestCase {
+class count_distinctTest extends \PHPUnit\Framework\TestCase {
 
     public function testCount_distinct() {