Merge pull request #243 from deliciousbrains/insert-on-duplicate-key-create

Creator handle INSERT statements with ON DUPLICATE KEY

Author: greenlion

src/PHPSQLParser/builders/RecordBuilder.php

@@ -75,7 +75,7 @@ protected function buildColRef($parsed) {
 
     public function build(array $parsed) {
         if ($parsed['expr_type'] !== ExpressionType::RECORD) {
-            return "";
+            return isset($parsed['base_expr']) ? $parsed['base_expr'] : '';
         }
         $sql = "";
         foreach ($parsed['data'] as $k => $v) {

src/PHPSQLParser/builders/ValuesBuilder.php

@@ -67,10 +67,13 @@ public function build(array $parsed) {
                 throw new UnableToCreateSQLException('VALUES', $k, $v, 'expr_type');
             }
 
-            $sql .= ", ";
+            $sql .= $this->getRecordDelimiter($v);
         }
-        $sql = substr($sql, 0, -2);
-        return "VALUES " . $sql;
+        return "VALUES " . trim($sql);
+    }
+
+    protected function getRecordDelimiter($parsed) {
+        return empty($parsed['delim']) ? ' ' : $parsed['delim'] . ' ';
     }
 }
 ?>

tests/cases/creator/issue242Test.php

@@ -0,0 +1,57 @@
+<?php
+/**
+ * issue242.php
+ *
+ * Test case for PHPSQLCreator.
+ */
+namespace PHPSQLParser\Test\Creator;
+
+use PHPSQLParser\PHPSQLParser;
+use PHPSQLParser\PHPSQLCreator;
+
+class Issue242Test extends \PHPUnit_Framework_TestCase {
+	
+	public function testOnDuplicateKey() {
+        $sql = "INSERT INTO `wp_options` (`option_name`, `option_value`, `autoload`) VALUES ('some_key', 'some_value', 'yes') ON DUPLICATE KEY UPDATE `option_name` = VALUES(`option_name`), `option_value` = VALUES(`option_value`), `autoload` = VALUES(`autoload`)";
+
+        $parser = new PHPSQLParser();
+		$parser->parse($sql);
+
+		$creator = new PHPSQLCreator();
+		$created = $creator->create($parser->parsed);
+		$this->assertEquals($sql, $created);
+	}
+
+    public function testOnDuplicateKeyAbsValues() {
+        $sql = "INSERT INTO wp_dh_wfConfig (name, val, autoload) values ('totalAlertsSent', '16', 'yes') ON DUPLICATE KEY UPDATE val = '16', autoload = 'yes';";
+
+        $parser = new PHPSQLParser();
+        $parser->parse($sql);
+
+        $creator = new PHPSQLCreator();
+        $created = $creator->create($parser->parsed);
+        $this->assertEquals($sql, $created);
+    }
+
+    public function testNormalInsert() {
+        $sql = "INSERT INTO `wp_options` (`option_name`, `option_value`, `autoload`) VALUES ('some_key', 'some_value', 'yes')";
+
+        $parser = new PHPSQLParser();
+        $parser->parse($sql);
+
+        $creator = new PHPSQLCreator();
+        $created = $creator->create($parser->parsed);
+        $this->assertEquals($sql, $created);
+    }
+
+    public function testNormalInsertMultipleValues() {
+        $sql = "INSERT INTO `wp_options` (`option_name`, `option_value`, `autoload`) VALUES ('some_key', 'some_value', 'yes'), ('some_key', 'some_value', 'yes')";
+
+        $parser = new PHPSQLParser();
+        $parser->parse($sql);
+
+        $creator = new PHPSQLCreator();
+        $created = $creator->create($parser->parsed);
+        $this->assertEquals($sql, $created);
+    }
+}