Skip to content

Commit c97f346

Browse files
lpotheratgreenlion
authored andcommitted
Move analog dependency to dev only (#307)
* Removed logError from HavingProcessor Since issue 10 is closed, there is no need to keep this log function * Move analog/analog to dev requirements Since issue 10 is closed, there is no need to keep analog in the production library * Removed use of Analog
1 parent 940ebb3 commit c97f346

2 files changed

Lines changed: 3 additions & 12 deletions

File tree

composer.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@
3737
}
3838
},
3939
"require" : {
40-
"php" : ">=5.3.2",
41-
"analog/analog" : "^1.0.6"
40+
"php" : ">=5.3.2"
4241
},
4342
"require-dev" : {
4443
"squizlabs/php_codesniffer" : "^1.5.1",
45-
"phpunit/phpunit" : "^4.0.14"
44+
"phpunit/phpunit" : "^4.0.14",
45+
"analog/analog" : "^1.0.6"
4646
}
4747
}

src/PHPSQLParser/processors/HavingProcessor.php

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141

4242
namespace PHPSQLParser\processors;
4343
use PHPSQLParser\utils\ExpressionType;
44-
use Analog\Analog;
4544

4645
/**
4746
* This class implements the processor for the HAVING statement.
@@ -52,13 +51,6 @@
5251
*
5352
*/
5453
class HavingProcessor extends ExpressionListProcessor {
55-
56-
// helper function to find an example for issue 10 on GitHub.com
57-
protected function logError($sql) {
58-
Analog::log("The alias clause of a colref is empty, this should not occur.", Analog::ALERT);
59-
Analog::log("Please create an issue on GitHub or GoogleCode with your SQL statement.", Analog::ALERT);
60-
Analog::log(print_r($sql, true), Analog::ALERT);
61-
}
6254

6355
public function process($tokens, $select = array()) {
6456
$parsed = parent::process($tokens);
@@ -67,7 +59,6 @@ public function process($tokens, $select = array()) {
6759
if ($v['expr_type'] === ExpressionType::COLREF) {
6860
foreach ($select as $clause) {
6961
if (!isset($clause['alias'])) {
70-
$this->logError($select);
7162
continue;
7263
}
7364
if (!$clause['alias']) {

0 commit comments

Comments
 (0)