[fix] some Type & Logic bugs of File Transfer methods

Author: TechQuery

package.json

@@ -1,6 +1,6 @@
 {
     "name": "mobx-lark",
-    "version": "2.6.1",
+    "version": "2.6.2-rc.0",
     "license": "LGPL-3.0",
     "author": "shiy2008@gmail.com",
     "description": "Unofficial TypeScript SDK for FeiShu/Lark API, which is based on MobX-RESTful.",

src/Lark.ts

@@ -5,8 +5,6 @@ import {
     CopiedFile,
     DocumentModel,
     DriveFileModel,
-    DriveFileType,
-    TransferOwnerRequest,
     UserIdType,
     WikiNode,
     WikiNodeModel
@@ -283,18 +281,4 @@ export class LarkApp implements LarkAppOption {
 
         return this.documentStore.getOneContent(doc_token, 'markdown');
     }
-
-    /**
-     * @see {@link DriveFileModel#transferOwner}
-     */
-    async transferFileOwner(
-        token: string,
-        type: DriveFileType,
-        request: TransferOwnerRequest,
-        user_id_type?: UserIdType
-    ) {
-        await this.getAccessToken();
-
-        return this.driveFileStore.transferOwner(token, type, request, user_id_type);
-    }
 }

src/module/Drive/index.ts

@@ -4,7 +4,7 @@ import { buildURLData, splitArray } from 'web-utility';
 
 import { LarkData, LarkDocumentPathTypeMap, LarkDocumentType, UploadTargetType } from '../../type';
 import { UserIdType } from '../User/type';
-import { CopiedFile, DriveFile, DriveFileType, TransferOwnerRequest } from './type';
+import { CopiedFile, DriveFile, DriveFileType, TransferOwner, TransferOption } from './type';
 
 export * from './type';
 
@@ -111,15 +111,14 @@ export abstract class DriveFileModel extends BaseListModel<DriveFile> {
      */
     @toggle('uploading')
     async transferOwner(
-        token: string,
         type: DriveFileType,
-        request: TransferOwnerRequest,
-        user_id_type?: UserIdType
+        token: string,
+        newOwner: TransferOwner,
+        option = {} as TransferOption
     ) {
-        const { body } = await this.client.post<LarkData>(
-            `${this.baseURI}/permissions/${token}/members/transfer_owner?${buildURLData({ type, user_id_type })}`,
-            request
+        await this.client.post<LarkData>(
+            `${this.baseURI}/permissions/${token}/members/transfer_owner?${buildURLData({ ...option, type })}`,
+            newOwner
         );
-        return body!.data;
     }
 }

src/module/Drive/type.ts

@@ -1,3 +1,5 @@
+import { LarkDocumentType } from '../../type';
+
 export type DriveFile = Record<
     | `doc_${'token' | 'type'}`
     | 'title'
@@ -9,20 +11,18 @@ export type DriveFile = Record<
     string
 >;
 
-export type CopiedFile = Record<'token' | 'type' | 'name' | 'parent_token' | 'url', string>;
+export type CopiedFile = Record<'type' | `${'parent_' | ''}token` | 'name' | 'url', string>;
+
+export type DriveFileType = LarkDocumentType | 'minutes' | 'folder' | 'wiki';
 
-export type DriveFileType =
-    | `doc${'' | 'x'}`
-    | 'sheet'
-    | 'file'
-    | 'wiki'
-    | 'bitable'
-    | 'folder'
-    | 'mindnote'
-    | 'slides';
+export interface TransferOwner {
+    member_type: 'email' | 'userid' | 'openid';
+    member_id: string;
+}
 
-export interface TransferOwnerRequest {
-    owner_id: string;
+export interface TransferOption {
+    need_notification?: boolean;
     remove_old_owner?: boolean;
-    cancel_notification?: boolean;
+    stay_put?: boolean;
+    old_owner_perm?: 'view' | 'edit' | 'full_access';
 }