Skip to content

Commit 756a016

Browse files
Replace go-makefile-maker workflows with manually maintained ones
Stop using go-makefile-maker for GitHub Actions workflow generation. With recent additions of custom workflows, maintaining consistency between auto-generated and manually written pipelines became impractical. The effort to update all workflows already requires reviewing each one, so auto-generation provides diminishing value. Additionally, some generated workflows like CodeQL are redundant (enabled at repo level) while others like test-chart required manual modifications anyway. Going forward, all workflows will be manually maintained for this project, providing full control over CI/CD configuration.
1 parent 7425ca6 commit 756a016

13 files changed

Lines changed: 232 additions & 339 deletions

.github/workflows/checks.yaml

Lines changed: 0 additions & 56 deletions
This file was deleted.

.github/workflows/ci.yaml

Lines changed: 0 additions & 79 deletions
This file was deleted.

.github/workflows/container-registry-ghcr.yaml

Lines changed: 0 additions & 58 deletions
This file was deleted.

.github/workflows/lint.yml

Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
1+
# SPDX-FileCopyrightText: 2026 SAP SE or an SAP affiliate company and IronCore contributors
2+
# SPDX-License-Identifier: Apache-2.0
3+
4+
name: Lint
5+
6+
on:
7+
pull_request:
8+
branches:
9+
- main
10+
paths-ignore:
11+
- 'docs/**'
12+
- '**/*.md'
13+
14+
jobs:
15+
lint:
16+
name: Check Go Code
17+
runs-on: ubuntu-latest
18+
steps:
19+
- uses: actions/checkout@v6
20+
- uses: actions/setup-go@v6
21+
with:
22+
go-version-file: 'go.mod'
23+
- name: Run golangci-lint
24+
uses: golangci/golangci-lint-action@v9
25+
with:
26+
version: latest
27+
vulnerabilities:
28+
name: Check Vulnerabilities
29+
runs-on: ubuntu-latest
30+
steps:
31+
- uses: actions/checkout@v6
32+
- uses: actions/setup-go@v6
33+
with:
34+
go-version: 'stable'
35+
- name: Install govulncheck
36+
run: go install golang.org/x/vuln/cmd/govulncheck@latest
37+
- name: Run govulncheck
38+
run: govulncheck -format text ./...
39+
spelling:
40+
name: Check Spelling Errors
41+
runs-on: ubuntu-latest
42+
steps:
43+
- uses: actions/checkout@v6
44+
- name: Run typos
45+
uses: crate-ci/typos@v1
46+
env:
47+
CLICOLOR: "1"
48+
shellcheck:
49+
name: Check Shell Scripts
50+
runs-on: ubuntu-latest
51+
steps:
52+
- uses: actions/checkout@v6
53+
- name: Run shellcheck
54+
uses: reviewdog/action-shellcheck@v1
55+
license:
56+
name: Check Licenses
57+
runs-on: ubuntu-latest
58+
steps:
59+
- uses: actions/checkout@v6
60+
- uses: actions/setup-go@v6
61+
with:
62+
go-version-file: 'go.mod'
63+
- name: Dependency Licenses Review
64+
run: make check-dependency-licenses
65+
- name: Check if source code files have license header
66+
run: make check-addlicense

.github/workflows/publish-docs.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,21 @@ name: Documentation
55

66
on:
77
push:
8-
branches: [main]
8+
branches:
9+
- main
910
pull_request:
10-
types: [ assigned, opened, synchronize, reopened ]
11-
workflow_dispatch:
12-
13-
permissions:
14-
contents: read
15-
pages: write
16-
id-token: write
11+
branches:
12+
- main
1713

1814
concurrency:
1915
group: pages
2016
cancel-in-progress: false
2117

18+
permissions:
19+
contents: read
20+
id-token: write
21+
pages: write
22+
2223
jobs:
2324
build:
2425
name: Build VitePress Site
Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
- uses: actions/checkout@v6
3232
- name: Extract metadata (tags, labels) for Docker
3333
id: meta
34-
uses: docker/metadata-action@v5
34+
uses: docker/metadata-action@v6
3535
with:
3636
images: ghcr.io/${{ github.repository }}
3737
tags: |
@@ -48,19 +48,25 @@ jobs:
4848
type=ref,event=pr
4949
# https://github.com/docker/metadata-action#typesha
5050
type=sha,format=long
51+
- name: Extract build-args for Docker
52+
id: build_args
53+
run: |
54+
echo "version=$(git describe --tags --always --abbrev=7)" >> $GITHUB_OUTPUT
55+
echo "commit=$(git rev-parse --verify HEAD)" >> $GITHUB_OUTPUT
56+
echo "date=$(date -u +'%Y-%m-%dT%H:%M:%SZ')" >> $GITHUB_OUTPUT
5157
- name: Set up QEMU
52-
uses: docker/setup-qemu-action@v3
58+
uses: docker/setup-qemu-action@v4
5359
- name: Set up Docker Buildx
54-
uses: docker/setup-buildx-action@v3
60+
uses: docker/setup-buildx-action@v4
5561
id: setup-buildx
5662
- name: Login to GitHub Container Registry
57-
uses: docker/login-action@v3
63+
uses: docker/login-action@v4
5864
with:
5965
registry: ghcr.io
6066
username: ${{ github.actor }}
6167
password: ${{ secrets.GITHUB_TOKEN }}
6268
- name: Go Cache for Docker
63-
uses: actions/cache@v4
69+
uses: actions/cache@v5
6470
id: cache
6571
with:
6672
path: |
@@ -78,9 +84,13 @@ jobs:
7884
skip-extraction: ${{ steps.cache.outputs.cache-hit }}
7985
builder: ${{ steps.setup-buildx.outputs.name }}
8086
- name: Build and push
81-
uses: docker/build-push-action@v6
87+
uses: docker/build-push-action@v7
8288
with:
8389
context: .
90+
build-args: |
91+
BININFO_VERSION=${{ steps.build_args.outputs.version }}
92+
BININFO_COMMIT_HASH=${{ steps.build_args.outputs.commit }}
93+
BININFO_BUILD_DATE=${{ steps.build_args.outputs.date }}
8494
platforms: linux/amd64,linux/arm64
8595
push: ${{ github.event_name != 'pull_request' }}
8696
tags: ${{ steps.meta.outputs.tags }}
Lines changed: 11 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,26 @@
1-
################################################################################
2-
# This file is AUTOGENERATED with <https://github.com/sapcc/go-makefile-maker> #
3-
# Edit Makefile.maker.yaml instead. #
4-
################################################################################
5-
6-
# SPDX-FileCopyrightText: 2024 SAP SE or an SAP affiliate company
1+
# SPDX-FileCopyrightText: 2026 SAP SE or an SAP affiliate company
72
# SPDX-License-Identifier: Apache-2.0
83

9-
name: goreleaser
10-
"on":
4+
name: Release
5+
6+
on:
117
push:
128
tags:
13-
- '*'
9+
- 'v*'
10+
1411
permissions:
1512
contents: write
1613
packages: write
14+
1715
jobs:
1816
release:
19-
name: goreleaser
17+
name: Publish Release
2018
runs-on: ubuntu-latest
2119
steps:
22-
- name: Check out code
23-
uses: actions/checkout@v6
24-
with:
25-
fetch-depth: 0
26-
- name: Set up Go
27-
uses: actions/setup-go@v6
20+
- uses: actions/checkout@v6
21+
- uses: actions/setup-go@v6
2822
with:
29-
check-latest: true
30-
go-version: 1.26.2
23+
go-version-file: 'go.mod'
3124
- name: Run prepare make target
3225
run: make generate
3326
- name: Install syft

0 commit comments

Comments
 (0)