Skip to content

Commit fc12b24

Browse files
committed
run make fix
1 parent 6af435d commit fc12b24

12 files changed

Lines changed: 608 additions & 301 deletions

File tree

src/admin.rs

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -515,11 +515,14 @@ mod tests {
515515
});
516516
for i in 0..2 {
517517
manager
518-
.fetch_certificate(&identity::Identity::Spiffe {
519-
trust_domain: "trust_domain".into(),
520-
namespace: "namespace".into(),
521-
service_account: strng::format!("sa-{i}"),
522-
}.to_composite_id())
518+
.fetch_certificate(
519+
&identity::Identity::Spiffe {
520+
trust_domain: "trust_domain".into(),
521+
namespace: "namespace".into(),
522+
service_account: strng::format!("sa-{i}"),
523+
}
524+
.to_composite_id(),
525+
)
523526
.await
524527
.unwrap();
525528
// Make sure certificates are a significant amount of time apart, for better
@@ -528,15 +531,19 @@ mod tests {
528531
}
529532

530533
manager
531-
.fetch_certificate(&identity("spiffe://error/ns/forgotten/sa/sa-failed").to_composite_id())
534+
.fetch_certificate(
535+
&identity("spiffe://error/ns/forgotten/sa/sa-failed").to_composite_id(),
536+
)
532537
.await
533538
.unwrap_err();
534539

535540
// Start a fetch asynchronously and proceed enough to have it pending, but not finish.
536541
let pending_manager = manager.clone();
537542
let pending_fetch = tokio::task::spawn(async move {
538543
pending_manager
539-
.fetch_certificate(&identity("spiffe://test/ns/test/sa/sa-pending").to_composite_id())
544+
.fetch_certificate(
545+
&identity("spiffe://test/ns/test/sa/sa-pending").to_composite_id(),
546+
)
540547
.await
541548
});
542549
tokio::time::sleep(Duration::from_nanos(1)).await;

src/app.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -316,13 +316,11 @@ fn new_data_plane_pool(num_worker_threads: usize) -> mpsc::Sender<DataPlaneTask>
316316
pub async fn build(config: Arc<config::Config>) -> anyhow::Result<Bound> {
317317
let cert_manager = if config.fake_ca {
318318
mock_secret_manager()
319+
} else if config.spire_enabled {
320+
let dc = DelegatedIdentityClient::default().await?;
321+
Arc::new(SecretManager::new_with_spire_client(config.clone(), dc).await?)
319322
} else {
320-
if config.spire_enabled {
321-
let dc = DelegatedIdentityClient::default().await?;
322-
Arc::new(SecretManager::new_with_spire_client(config.clone(), dc).await?)
323-
} else {
324-
Arc::new(SecretManager::new(config.clone()).await?)
325-
}
323+
Arc::new(SecretManager::new(config.clone()).await?)
326324
};
327325
build_with_cert(config, cert_manager).await
328326
}

src/cert_fetcher.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,7 @@ impl CertFetcherImpl {
109109
RequestKeyEnum::Workload(WorkloadUid::new(w.uid.to_string())),
110110
)
111111
} else {
112-
CompositeId::new(
113-
w.identity(),
114-
RequestKeyEnum::Identity(w.identity().clone()),
115-
)
112+
CompositeId::new(w.identity(), RequestKeyEnum::Identity(w.identity().clone()))
116113
}
117114
}
118115
}

src/config.rs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -878,9 +878,15 @@ pub fn construct_config(pc: ProxyConfig) -> Result<Config, Error> {
878878
ztunnel_workload,
879879
ipv6_enabled,
880880
spire_enabled: parse_default(SPIRE_ENABLED, false)?,
881-
container_runtime_sock_path: parse_default(CONTAINER_RUNTIME_SOCK_PATH, "/run/containerd/containerd.sock".to_string())?,
881+
container_runtime_sock_path: parse_default(
882+
CONTAINER_RUNTIME_SOCK_PATH,
883+
"/run/containerd/containerd.sock".to_string(),
884+
)?,
882885
spire_timeout: parse_duration_default(SPIRE_TIMEOUT, Duration::from_secs(10))?,
883-
spire_admin_socket: parse_default(SPIRE_ADMIN_SOCKET, "unix:///run/spire/sockets/admin.sock".to_string())?,
886+
spire_admin_socket: parse_default(
887+
SPIRE_ADMIN_SOCKET,
888+
"unix:///run/spire/sockets/admin.sock".to_string(),
889+
)?,
884890
})
885891
}
886892

0 commit comments

Comments
 (0)