Experimental VA logs IPs in base64

[mcpherrinm]

That doesn't match the usual "Validation result" format. addressUsed and addressesResolved should be printed as plain text.

6 boulder-va Vrnp4Q [AUDIT] Primary VA disagreed with experimental VA JSON={
  "experimentPassed": false,
  "experimentResult": {
    "records": [
      {
        "hostname": "r1775515180z781e2d8a.dev.monitor.radiantlock.org",
        "port": "80",
        "addressesResolved": [
          "QHB1eg=="
        ],
        "addressUsed": "NjQuMTEyLjExNy4xMjI=",
        "url": "http://r1775515180z781e2d8a.dev.monitor.radiantlock.org/.well-known/acme-challenge/557Y2B4hIV-ljj72lqsJWmHC7QheXxEfapgjpA2Jd0s",
        "resolverAddrs": [
          "10.4.12.82:26107",
          "10.4.12.82:26107"
        ]
      }
    ],
    "problem": {
      "problemType": "connection",
      "detail": "64.112.117.122: Fetching http://r1775515180z781e2d8a.dev.monitor.radiantlock.org/.well-known/acme-challenge/557Y2B4hIV-ljj72lqsJWmHC7QheXxEfapgjpA2Jd0s: Connection refused",
      "httpStatus": 400
    },
    "perspective": "Experimental"
  },
  "operation": "dcv",
  "primaryPassed": true,
  "primaryResult": {
    "records": [
      {
        "hostname": "r1775515180z781e2d8a.dev.monitor.radiantlock.org",
        "port": "80",
        "addressesResolved": [
          "QHB1ew=="
        ],
        "addressUsed": "NjQuMTEyLjExNy4xMjM=",
        "url": "http://r1775515180z781e2d8a.dev.monitor.radiantlock.org/.well-known/acme-challenge/557Y2B4hIV-ljj72lqsJWmHC7QheXxEfapgjpA2Jd0s",
        "resolverAddrs": [
          "10.4.12.82:28649",
          "10.4.12.82:28649"
        ]
      }
    ],
    "perspective": "Primary"
  }
}

[jsha]

For the "Validation result" log event we have a field Challenge core.Challenge (

boulder/va/va.go

Line 719 in e139723

Challenge core.Challenge

). core.Challenge in turn contains a core.ValidationRecord (

boulder/core/objects.go

Line 105 in e139723

type ValidationRecord struct {

), which represents AddressesResolved and AddressesUsed as netip.Addr, so they get JSON-marshaled correctly.

For the "Primary VA disagreed with experimental VA" log line, we use primary and experimentResult
(

boulder/va/va.go

Lines 327 to 329 in e139723

	"primaryResult": primary,
	"experimentPassed": experimentPassed,
	"experimentResult": experimentResult,

), which are of type remoteResult (an interface), but their underlying type is either *vapb.IsCAAValidResponse or *vapb.ValidationResult depending on whether we're doing CAA or DCV.

We should probably do a type-switch here, and log specific fields of each proto as appropriate. There is in fact a grpc.pbToValidationResult that we could make exported and use (it's both unexported and unused!). But I think we should go the other direction and have less conflation between our ACME JSON types (largely in core) and our internal logging types. That argues in favor of having specific logging functions for ValidationResult and IsCAAValidResponse that make sure to serialize relevant fields appropriately.