correctly handle group/entry repr when path contains None

Author: Evidlo

pykeepass/entry.py

@@ -220,6 +220,9 @@ def is_a_history_entry(self):
 
     @property
     def path(self):
+        """Path to element as list.  List contains all parent group names
+        ending with entry title.  List may contain strings or NoneTypes."""
+
         # The root group is an orphan
         if self.parentgroup is None:
             return None
@@ -282,7 +285,8 @@ def save_history(self):
             self._element.append(history)
 
     def __str__(self):
-        pathstr = '/'.join(self.path)
+        # filter out NoneTypes and join into string
+        pathstr = '/'.join('' if p==None else p for p in self.path)
         if self.is_a_history_entry:
             return '[History of: {}]'.format(pathstr)
         return 'Entry: "{} ({})"'.format(pathstr, self.username)

pykeepass/group.py

@@ -94,5 +94,6 @@ def append(self, entries):
             self._element.append(entries._element)
 
     def __str__(self):
-        pathstr = '/'.join(self.path)
+        # filter out NoneTypes and join into string
+        pathstr = '/'.join('' if p==None else p for p in self.path)
         return 'Group: "{}"'.format(pathstr)

tests/test3.kdbx

@@ -277,6 +277,11 @@ def test_print_entries(self):
         self.assertIsInstance(e.__repr__(), str)
         self.assertIsInstance(e.history.__repr__(), str)
 
+        # issue 250
+        e = self.kp.find_entries(username='blank_title', first=True)
+        self.assertIsNot(e, None)
+        self.assertIsInstance(e.__repr__(), str)
+
 
 class GroupFindTests3(KDBX3Tests):
 
@@ -317,7 +322,7 @@ def test_find_groups_by_notes(self):
     def test_groups(self):
         results = self.kp.groups
 
-        self.assertEqual(len(results), 6)
+        self.assertEqual(len(results), 7)
 
     # ---------- Adding/Deleting Groups -----------
 
@@ -349,6 +354,10 @@ def test_add_delete_move_group(self):
     def test_print_groups(self):
         self.assertIsInstance(self.kp.groups.__repr__(), str)
 
+        g = self.kp.find_groups(notes='blank_name')
+        self.assertIsNot(g, None)
+        self.assertIsInstance(g.__repr__(), str)
+
 class RecycleBinTests3(KDBX3Tests):
 
     def test_recyclebincreation(self):