Chore(healthCheck): Update default healthCheck tunable in engine (#183)

Signed-off-by: uditgaurav <udit@chaosnative.com>

Author: uditgaurav

go.mod

@@ -4,7 +4,7 @@ go 1.17
 
 require (
 	github.com/jpillora/go-ogle-analytics v0.0.0-20161213085824-14b04e0594ef
-	github.com/litmuschaos/chaos-operator v0.0.0-20220929101337-868b2827f820
+	github.com/litmuschaos/chaos-operator v0.0.0-20221006080214-d78985569b82
 	github.com/litmuschaos/elves v0.0.0-20210325101625-5620f93aed51
 	github.com/litmuschaos/litmus-go v0.0.0-20220927112726-25d81a302a70
 	github.com/onsi/ginkgo v1.16.5

go.sum

@@ -738,8 +738,8 @@ github.com/lightstep/lightstep-tracer-common/golang/gogo v0.0.0-20190605223551-b
 github.com/lightstep/lightstep-tracer-go v0.18.0/go.mod h1:jlF1pusYV4pidLvZ+XD0UBX0ZE6WURAspgAczcDHrL4=
 github.com/lithammer/dedent v1.1.0/go.mod h1:jrXYCQtgg0nJiN+StA2KgR7w6CiQNv9Fd/Z9BP0jIOc=
 github.com/litmuschaos/chaos-operator v0.0.0-20220927085333-f70f80b9e75f/go.mod h1:CJGiHqC06PQkIBySk/JroB7B2zFebDbkhQ1A6ZbYmHA=
-github.com/litmuschaos/chaos-operator v0.0.0-20220929101337-868b2827f820 h1:xMlb6eMbWzdR/2IB6F095p0NDadccZIkiovJBE9fg9I=
-github.com/litmuschaos/chaos-operator v0.0.0-20220929101337-868b2827f820/go.mod h1:CJGiHqC06PQkIBySk/JroB7B2zFebDbkhQ1A6ZbYmHA=
+github.com/litmuschaos/chaos-operator v0.0.0-20221006080214-d78985569b82 h1:FB9P0pfG1bwdb63I9xfZByr3szjfndE8UDOcm4H08xQ=
+github.com/litmuschaos/chaos-operator v0.0.0-20221006080214-d78985569b82/go.mod h1:CJGiHqC06PQkIBySk/JroB7B2zFebDbkhQ1A6ZbYmHA=
 github.com/litmuschaos/elves v0.0.0-20201107015738-552d74669e3c/go.mod h1:DsbHGNUq/78NZozWVVI9Q6eBei4I+JjlkkD5aibJ3MQ=
 github.com/litmuschaos/elves v0.0.0-20210325101625-5620f93aed51 h1:6CpcGjZsVHMRSB/Z8z9+ectmb1KuQUiy+244jISNhBA=
 github.com/litmuschaos/elves v0.0.0-20210325101625-5620f93aed51/go.mod h1:DsbHGNUq/78NZozWVVI9Q6eBei4I+JjlkkD5aibJ3MQ=

pkg/utils/engineHelper.go

@@ -26,7 +26,7 @@ func (expDetails *ExperimentDetails) SetInstanceAttributeValuesFromChaosEngine(e
 		SetTolerationsFromEngine(chaosEngine).
 		SetExpImageFromEngine(chaosEngine).
 		SetTerminationGracePeriodSecondsFromEngine(chaosEngine).
-		SetDefaultAppHealthCheck(chaosEngine)
+		SetDefaultHealthCheck(chaosEngine)
 
 	return nil
 }
@@ -108,9 +108,9 @@ func (expDetails *ExperimentDetails) SetTolerationsFromEngine(engine *litmuschao
 	return expDetails
 }
 
-// SetDefaultAppHealthCheck sets th default health checks provided inside the chaosEngine
-func (expDetails *ExperimentDetails) SetDefaultAppHealthCheck(engine *litmuschaosv1alpha1.ChaosEngine) *ExperimentDetails {
-	expDetails.DefaultAppHealthCheck = engine.Spec.DefaultAppHealthCheck
+// SetDefaultHealthCheck sets th default health checks provided inside the chaosEngine
+func (expDetails *ExperimentDetails) SetDefaultHealthCheck(engine *litmuschaosv1alpha1.ChaosEngine) *ExperimentDetails {
+	expDetails.DefaultHealthCheck = engine.Spec.DefaultHealthCheck
 	return expDetails
 }
 

pkg/utils/environment.go

@@ -51,7 +51,7 @@ func (expDetails *ExperimentDetails) SetENV(engineDetails EngineDetails, clients
 		setEnv("ANNOTATION_CHECK", engineDetails.AnnotationCheck).
 		setEnv("LIB_IMAGE_PULL_POLICY", string(expDetails.ExpImagePullPolicy)).
 		setEnv("TERMINATION_GRACE_PERIOD_SECONDS", strconv.Itoa(int(expDetails.TerminationGracePeriodSeconds))).
-		setEnv("DEFAULT_APP_HEALTH_CHECK", expDetails.DefaultAppHealthCheck).
+		setEnv("DEFAULT_HEALTH_CHECK", expDetails.DefaultHealthCheck).
 		setEnv("CHAOS_SERVICE_ACCOUNT", expDetails.SvcAccount)
 
 	// Get the Default ENV's from ChaosExperiment

pkg/utils/event_test.go

@@ -2,11 +2,12 @@ package utils
 
 import (
 	"context"
-	"github.com/stretchr/testify/require"
 	"strings"
 	"testing"
 	"time"
 
+	"github.com/stretchr/testify/require"
+
 	v1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	clientTypes "k8s.io/apimachinery/pkg/types"

pkg/utils/types.go

@@ -59,7 +59,7 @@ type ExperimentDetails struct {
 	ImagePullSecrets              []v1.LocalObjectReference
 	StatusCheckTimeout            int
 	TerminationGracePeriodSeconds int64
-	DefaultAppHealthCheck         string
+	DefaultHealthCheck            string
 }
 
 //VolumeOpts is a strcuture for all volume related operations