Added Trimspace

Signed-off-by: chinmaym07 <b418020@iiit-bh.ac.in>

Author: chinmaym07

chaoslib/litmus/aws-ssm-chaos/lib/ssm/aws-ssm-chaos-by-id.go

@@ -50,7 +50,7 @@ func PrepareAWSSSMChaosByID(experimentsDetails *experimentTypes.ExperimentDetail
 	// watching for the abort signal and revert the chaos
 	go lib.AbortWatcher(experimentsDetails, abort)
 
-	if experimentsDetails.EC2InstanceID == "" {
+	if strings.TrimSpace(experimentsDetails.EC2InstanceID) == "" {
 		return errors.Errorf("no instance id found for chaos injection")
 	}
 	//get the instance id or list of instance ids

chaoslib/litmus/azure-disk-loss/lib/azure-disk-loss.go

@@ -44,7 +44,7 @@ func PrepareChaos(experimentsDetails *experimentTypes.ExperimentDetails, clients
 		log.Infof("[Ramp]: Waiting for the %vs ramp time before injecting chaos", experimentsDetails.RampTime)
 		common.WaitForDuration(experimentsDetails.RampTime)
 	}
-	if experimentsDetails.VirtualDiskNames == "" {
+	if strings.TrimSpace(experimentsDetails.VirtualDiskNames) == "" {
 		return errors.Errorf("no volume names found to detach")
 	}
 	//get the disk name  or list of disk names

chaoslib/litmus/azure-instance-stop/lib/azure-instance-stop.go

@@ -41,7 +41,7 @@ func PrepareAzureStop(experimentsDetails *experimentTypes.ExperimentDetails, cli
 		log.Infof("[Ramp]: Waiting for the %vs ramp time before injecting chaos", experimentsDetails.RampTime)
 		common.WaitForDuration(experimentsDetails.RampTime)
 	}
-	if experimentsDetails.AzureInstanceName == "" {
+	if strings.TrimSpace(experimentsDetails.AzureInstanceName) == "" {
 		return errors.Errorf("no instance name found to stop")
 	}
 	//  get the instance name or list of instance names

chaoslib/litmus/container-kill/lib/container-kill.go

@@ -26,7 +26,7 @@ func PrepareContainerKill(experimentsDetails *experimentTypes.ExperimentDetails,
 	var podsAffectedPerc int
 	// Get the target pod details for the chaos execution
 	// if the target pod is not defined it will derive the random target pod list using pod affected percentage
-	if experimentsDetails.TargetPods == "" && chaosDetails.AppDetail.Label == "" {
+	if strings.TrimSpace(experimentsDetails.TargetPods) == "" && strings.TrimSpace(chaosDetails.AppDetail.Label) == "" {
 		return errors.Errorf("please provide one of the appLabel or TARGET_PODS")
 	}
 	//Setup the tunables if provided in range
@@ -38,13 +38,13 @@ func PrepareContainerKill(experimentsDetails *experimentTypes.ExperimentDetails,
 	})
 
 	podsAffectedPerc, _ = strconv.Atoi(experimentsDetails.PodsAffectedPerc)
-	if experimentsDetails.NodeLabel == "" {
+	if strings.TrimSpace(experimentsDetails.NodeLabel) == "" {
 		targetPodList, err = common.GetPodList(experimentsDetails.TargetPods, podsAffectedPerc, clients, chaosDetails)
 		if err != nil {
 			return err
 		}
 	} else {
-		if experimentsDetails.TargetPods == "" {
+		if strings.TrimSpace(experimentsDetails.TargetPods) == "" {
 			targetPodList, err = common.GetPodListFromSpecifiedNodes(experimentsDetails.TargetPods, podsAffectedPerc, experimentsDetails.NodeLabel, clients, chaosDetails)
 			if err != nil {
 				return err
@@ -71,14 +71,14 @@ func PrepareContainerKill(experimentsDetails *experimentTypes.ExperimentDetails,
 	}
 
 	// Getting the serviceAccountName, need permission inside helper pod to create the events
-	if experimentsDetails.ChaosServiceAccount == "" {
+	if strings.TrimSpace(experimentsDetails.ChaosServiceAccount) == "" {
 		experimentsDetails.ChaosServiceAccount, err = common.GetServiceAccount(experimentsDetails.ChaosNamespace, experimentsDetails.ChaosPodName, clients)
 		if err != nil {
 			return errors.Errorf("unable to get the serviceAccountName, err: %v", err)
 		}
 	}
 
-	if experimentsDetails.EngineName != "" {
+	if strings.TrimSpace(experimentsDetails.EngineName) != "" {
 		if err := common.SetHelperData(chaosDetails, experimentsDetails.SetHelperData, clients); err != nil {
 			return err
 		}

chaoslib/litmus/disk-fill/lib/disk-fill.go

@@ -29,7 +29,7 @@ func PrepareDiskFill(experimentsDetails *experimentTypes.ExperimentDetails, clie
 	execCommandDetails := exec.PodDetails{}
 	// Get the target pod details for the chaos execution
 	// if the target pod is not defined it will derive the random target pod list using pod affected percentage
-	if experimentsDetails.TargetPods == "" && chaosDetails.AppDetail.Label == "" {
+	if strings.TrimSpace(experimentsDetails.TargetPods) == "" && strings.TrimSpace(chaosDetails.AppDetail.Label) == "" {
 		return errors.Errorf("please provide one of the appLabel or TARGET_PODS")
 	}
 	//setup the tunables if provided in range
@@ -43,13 +43,13 @@ func PrepareDiskFill(experimentsDetails *experimentTypes.ExperimentDetails, clie
 	})
 
 	podsAffectedPerc, _ = strconv.Atoi(experimentsDetails.PodsAffectedPerc)
-	if experimentsDetails.NodeLabel == "" {
+	if strings.TrimSpace(experimentsDetails.NodeLabel) == "" {
 		targetPodList, err = common.GetPodList(experimentsDetails.TargetPods, podsAffectedPerc, clients, chaosDetails)
 		if err != nil {
 			return err
 		}
 	} else {
-		if experimentsDetails.TargetPods == "" {
+		if strings.TrimSpace(experimentsDetails.TargetPods) == "" {
 			targetPodList, err = common.GetPodListFromSpecifiedNodes(experimentsDetails.TargetPods, podsAffectedPerc, experimentsDetails.NodeLabel, clients, chaosDetails)
 			if err != nil {
 				return err
@@ -76,7 +76,7 @@ func PrepareDiskFill(experimentsDetails *experimentTypes.ExperimentDetails, clie
 	}
 
 	// Getting the serviceAccountName, need permission inside helper pod to create the events
-	if experimentsDetails.ChaosServiceAccount == "" {
+	if strings.TrimSpace(experimentsDetails.ChaosServiceAccount) == "" {
 		experimentsDetails.ChaosServiceAccount, err = common.GetServiceAccount(experimentsDetails.ChaosNamespace, experimentsDetails.ChaosPodName, clients)
 		if err != nil {
 			return errors.Errorf("unable to get the serviceAccountName, err: %v", err)

chaoslib/litmus/docker-service-kill/lib/docker-service-kill.go

@@ -3,6 +3,7 @@ package lib
 import (
 	"context"
 	"strconv"
+	"strings"
 
 	clients "github.com/litmuschaos/litmus-go/pkg/clients"
 	"github.com/litmuschaos/litmus-go/pkg/events"
@@ -22,7 +23,7 @@ import (
 func PrepareDockerServiceKill(experimentsDetails *experimentTypes.ExperimentDetails, clients clients.ClientSets, resultDetails *types.ResultDetails, eventsDetails *types.EventDetails, chaosDetails *types.ChaosDetails) error {
 
 	var err error
-	if experimentsDetails.TargetNode == "" {
+	if strings.TrimSpace(experimentsDetails.TargetNode) == "" {
 		//Select node for docker-service-kill
 		experimentsDetails.TargetNode, err = common.GetNodeName(experimentsDetails.AppNS, experimentsDetails.AppLabel, experimentsDetails.NodeLabel, clients)
 		if err != nil {

chaoslib/litmus/ebs-loss/lib/ebs-loss-by-id/lib/ebs-loss-by-id.go

@@ -44,7 +44,7 @@ func PrepareEBSLossByID(experimentsDetails *experimentTypes.ExperimentDetails, c
 		// stopping the chaos execution, if abort signal received
 		os.Exit(0)
 	default:
-		if experimentsDetails.EBSVolumeID == "" {
+		if strings.TrimSpace(experimentsDetails.EBSVolumeID) == "" {
 			return errors.Errorf("no volume id found to detach")
 		}
 		//get the volume id or list of instance ids

chaoslib/litmus/ebs-loss/lib/ebs-loss.go

@@ -2,6 +2,7 @@ package lib
 
 import (
 	"os"
+	"strings"
 	"time"
 
 	clients "github.com/litmuschaos/litmus-go/pkg/clients"
@@ -112,7 +113,7 @@ func InjectChaosInParallelMode(experimentsDetails *experimentTypes.ExperimentDet
 		//prepare the instaceIDs and device name for all the given volume
 		for _, volumeID := range targetEBSVolumeIDList {
 			ec2InstanceID, device, err := ebs.GetVolumeAttachmentDetails(volumeID, experimentsDetails.VolumeTag, experimentsDetails.Region)
-			if err != nil || ec2InstanceID == "" || device == "" {
+			if err != nil || strings.TrimSpace(ec2InstanceID) == "" || strings.TrimSpace(device) == "" {
 				return errors.Errorf("fail to get the attachment info, err: %v", err)
 			}
 			ec2InstanceIDList = append(ec2InstanceIDList, ec2InstanceID)

chaoslib/litmus/ec2-terminate-by-id/lib/ec2-terminate-by-id.go

@@ -41,7 +41,7 @@ func PrepareEC2TerminateByID(experimentsDetails *experimentTypes.ExperimentDetai
 		log.Infof("[Ramp]: Waiting for the %vs ramp time before injecting chaos", experimentsDetails.RampTime)
 		common.WaitForDuration(experimentsDetails.RampTime)
 	}
-	if experimentsDetails.Ec2InstanceID == "" {
+	if strings.TrimSpace(experimentsDetails.Ec2InstanceID) == "" {
 		return errors.Errorf("no instance id found to terminate")
 	}
 	//get the instance id or list of instance ids

chaoslib/litmus/gcp-vm-disk-loss-by-label/lib/gcp-vm-disk-loss-by-label.go

@@ -284,7 +284,7 @@ func getDeviceNamesAndVMInstanceNames(diskVolumeNamesList []string, computeServi
 	for i := range diskVolumeNamesList {
 
 		instanceName, err := gcp.GetVolumeAttachmentDetails(computeService, experimentsDetails.GCPProjectID, experimentsDetails.DiskZones, diskVolumeNamesList[i])
-		if err != nil || instanceName == "" {
+		if err != nil || strings.TrimSpace(instanceName) == "" {
 			return errors.Errorf("failed to get the attachment info, err: %v", err)
 		}