Skip to content

Commit 47053cc

Browse files
authored
apacheGH-49728: [CI] Set persist-credentials: false in checkout actions (apache#49734)
### Rationale for this change Some CI jobs didn't have persist-credential set to false, which presents potential risks ### What changes are included in this PR? Set persist-credentials to false ### Are these changes tested? Run CI jobs ### Are there any user-facing changes? No * GitHub Issue: apache#49728 Authored-by: Nic Crane <[email protected]> Signed-off-by: Nic Crane <[email protected]>
1 parent 41035d4 commit 47053cc

23 files changed

Lines changed: 63 additions & 0 deletions

.github/workflows/archery.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ jobs:
6060
- name: Checkout Arrow
6161
uses: actions/checkout@v6
6262
with:
63+
persist-credentials: false
6364
fetch-depth: 0
6465
- name: Git Fixup
6566
shell: bash

.github/workflows/check_labels.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ jobs:
4848
- name: Checkout Arrow
4949
if: github.event_name == 'pull_request'
5050
uses: actions/checkout@v6
51+
with:
52+
persist-credentials: false
5153
- name: Check
5254
id: check
5355
env:

.github/workflows/comment_bot.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ jobs:
3838
- name: Checkout Arrow
3939
uses: actions/checkout@v6
4040
with:
41+
persist-credentials: false
4142
path: arrow
4243
# fetch the tags for version number generation
4344
fetch-depth: 0

.github/workflows/cpp.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ jobs:
116116
- name: Checkout Arrow
117117
uses: actions/checkout@v6
118118
with:
119+
persist-credentials: false
119120
fetch-depth: 0
120121
submodules: recursive
121122
- name: Cache Docker Volumes
@@ -169,6 +170,7 @@ jobs:
169170
- name: Checkout Arrow
170171
uses: actions/checkout@v6
171172
with:
173+
persist-credentials: false
172174
fetch-depth: 0
173175
submodules: recursive
174176
- name: Check CMake presets
@@ -224,6 +226,7 @@ jobs:
224226
- name: Checkout Arrow
225227
uses: actions/checkout@v6
226228
with:
229+
persist-credentials: false
227230
fetch-depth: 0
228231
submodules: recursive
229232
- name: Install Dependencies
@@ -353,6 +356,7 @@ jobs:
353356
- name: Checkout Arrow
354357
uses: actions/checkout@v6
355358
with:
359+
persist-credentials: false
356360
fetch-depth: 0
357361
submodules: recursive
358362
- uses: msys2/setup-msys2@v2

.github/workflows/cpp_extra.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ jobs:
139139
- name: Checkout Arrow
140140
uses: actions/checkout@v6
141141
with:
142+
persist-credentials: false
142143
fetch-depth: 0
143144
submodules: recursive
144145
- name: Cache Docker Volumes
@@ -221,6 +222,7 @@ jobs:
221222
- name: Checkout Arrow
222223
uses: actions/checkout@v6
223224
with:
225+
persist-credentials: false
224226
fetch-depth: 0
225227
submodules: recursive
226228
- name: Free up disk space
@@ -273,6 +275,7 @@ jobs:
273275
- name: Checkout Arrow
274276
uses: actions/checkout@v6
275277
with:
278+
persist-credentials: false
276279
fetch-depth: 0
277280
submodules: recursive
278281
- name: Install dependencies
@@ -367,6 +370,7 @@ jobs:
367370
- name: Checkout Arrow
368371
uses: actions/checkout@v6
369372
with:
373+
persist-credentials: false
370374
fetch-depth: 0
371375
submodules: recursive
372376
- name: Cache Docker Volumes
@@ -431,6 +435,7 @@ jobs:
431435
- name: Checkout Arrow
432436
uses: actions/[email protected]
433437
with:
438+
persist-credentials: false
434439
fetch-depth: 0
435440
submodules: recursive
436441
- name: Install Dependencies
@@ -552,6 +557,7 @@ jobs:
552557
- name: Checkout Arrow
553558
uses: actions/checkout@v6
554559
with:
560+
persist-credentials: false
555561
fetch-depth: 0
556562
submodules: recursive
557563
- name: Download Timezone Database
@@ -579,6 +585,7 @@ jobs:
579585
- name: Checkout vcpkg
580586
uses: actions/checkout@v6
581587
with:
588+
persist-credentials: false
582589
fetch-depth: 0
583590
path: vcpkg
584591
repository: microsoft/vcpkg
@@ -706,6 +713,7 @@ jobs:
706713
- name: Checkout Arrow
707714
uses: actions/checkout@v6
708715
with:
716+
persist-credentials: false
709717
fetch-depth: 1
710718
path: arrow
711719
repository: apache/arrow
@@ -736,6 +744,7 @@ jobs:
736744
- name: Checkout Arrow
737745
uses: actions/checkout@v6
738746
with:
747+
persist-credentials: false
739748
fetch-depth: 0
740749
submodules: recursive
741750
- name: Download the artifacts

.github/workflows/cpp_windows.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ jobs:
8484
- name: Checkout Arrow
8585
uses: actions/checkout@v6
8686
with:
87+
persist-credentials: false
8788
fetch-depth: 0
8889
submodules: recursive
8990
- name: Install msys2 (for tzdata for ORC tests)

.github/workflows/cuda_extra.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ jobs:
8585
- name: Checkout Arrow
8686
uses: actions/checkout@v6
8787
with:
88+
persist-credentials: false
8889
fetch-depth: 0
8990
submodules: recursive
9091
- name: Cache Docker Volumes

.github/workflows/dev.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ jobs:
4949
- name: Checkout Arrow
5050
uses: actions/checkout@v6
5151
with:
52+
persist-credentials: false
5253
fetch-depth: 0
5354
- name: Install pre-commit
5455
run: |
@@ -88,6 +89,7 @@ jobs:
8889
- name: Checkout Arrow
8990
uses: actions/checkout@v6
9091
with:
92+
persist-credentials: false
9193
fetch-depth: 0
9294
- name: Install Python
9395
uses: actions/setup-python@v6

.github/workflows/docs.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ jobs:
5151
- name: Checkout Arrow
5252
uses: actions/checkout@v6
5353
with:
54+
persist-credentials: false
5455
fetch-depth: 0
5556
- name: Free up disk space
5657
run: |

.github/workflows/docs_light.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ jobs:
5252
- name: Checkout Arrow
5353
uses: actions/checkout@v6
5454
with:
55+
persist-credentials: false
5556
fetch-depth: 0
5657
- name: Cache Docker Volumes
5758
uses: actions/cache@v5

0 commit comments

Comments
 (0)