Fixed absolute path detection (#8)

* Fixed absolute path detection

* Added folder for tests in scrutinizer

* Trying to fix the regex

* Fixed issue with regex and added unit test

* Removed capturing group

Author: mcustiel

src/Module/Phiremock.php

@@ -63,6 +63,7 @@ public function __construct(ModuleContainer $moduleContainer, $config = null, bo
     }
 
     /**
+     * @param mixed $settings
      * @throws ConfigurationException
      * @throws Exception
      */
@@ -174,9 +175,22 @@ public function setScenarioState(string $name, string $state): void
         $this->phiremock->setScenarioState($name, $state);
     }
 
+    /** @throws ModuleException */
+    protected function setupExtraConnections(): void
+    {
+        if (!$this->isExtraConfig) {
+            foreach ($this->moduleConfig->getExtraConnectionsConfigs() as $name => $connectionConfig) {
+                if ($name === 'default') {
+                    throw new ModuleException($this, 'The connection name "default" is reserved and can not be used for an extra connection');
+                }
+                $this->extraConnections[$name] = new self($this->moduleContainer, $connectionConfig->asArray(), true);
+            }
+        }
+    }
+
     private function createDebugMethod(): callable
     {
-        return function (string $msg) : void {
+        return function (string $msg): void {
             $this->debug($msg);
         };
     }
@@ -225,17 +239,4 @@ private function extraConfigsBefore(TestInterface $test): void
             }
         }
     }
-
-    /** @throws ModuleException */
-    protected function setupExtraConnections(): void
-    {
-        if (!$this->isExtraConfig) {
-            foreach ($this->moduleConfig->getExtraConnectionsConfigs() as $name => $connectionConfig) {
-                if ($name === 'default') {
-                    throw new ModuleException($this, 'The connection name "default" is reserved and can not be used for an extra connection');
-                }
-                $this->extraConnections[$name] = new self($this->moduleContainer, $connectionConfig->asArray(), true);
-            }
-        }
-    }
 }

src/Util/Config.php

@@ -67,7 +67,6 @@ public function __construct(array $config, callable $output)
         $this->clientFactory = $this->getFactoryClass($config);
         $this->initExtraConnections($config);
         $this->secure = $config['secure'];
-
     }
 
     /** @return Config[] */

src/Util/DirectoryPath.php

@@ -55,7 +55,7 @@ public static function createAndGetInstance(string $path): self
     /** @throws ConfigurationException */
     public static function createAbsoluteOrRelativeToCodeceptionDir(string $path): self
     {
-        if (substr($path, 0, 1) === '/') {
+        if (preg_match('~^(?:[a-z]:\\\|/)~i', $path) === 1) {
             return new self($path);
         }
         return new self(Configuration::projectDir() . $path);

tests/unit/DirectoryPathCest.php

@@ -0,0 +1,31 @@
+<?php
+
+use Codeception\Exception\ConfigurationException;
+use Mcustiel\Phiremock\Codeception\Util\DirectoryPath;
+
+class DirectoryPathCest
+{
+    public function testWindowsFullPath(UnitTester $I): void
+    {
+        try {
+            DirectoryPath::createAbsoluteOrRelativeToCodeceptionDir('C:\\PotatoPhiremock');
+        } catch (ConfigurationException $e) {
+            $I->assertSame(
+                'Could not find the configured expectations path: C:\\PotatoPhiremock',
+                $e->getMessage()
+            );
+        }
+    }
+
+    public function testLinuxFullPath(UnitTester $I): void
+    {
+        try {
+            DirectoryPath::createAbsoluteOrRelativeToCodeceptionDir('/home/phiremock/potato');
+        } catch (ConfigurationException $e) {
+            $I->assertSame(
+                'Could not find the configured expectations path: /home/phiremock/potato',
+                $e->getMessage()
+            );
+        }
+    }
+}