Compose isNonPassingTestStatus() more dynamically.

ericsnowcurrently · ericsnowcurrently · commit 085d29a921e9 · 2021-02-16T10:16:04.000-07:00
diff --git a/src/client/testing/common/types.ts b/src/client/testing/common/types.ts
@@ -96,8 +96,9 @@ export enum TestStatus {
 export type FinalTestStatus = TestStatus.Fail | TestStatus.Error | TestStatus.Skipped | TestStatus.Pass;
 export type NonPassingTestStatus = Exclude<FinalTestStatus, TestStatus.Pass>;
 
+const nonPassing = Object.values(TestStatus).filter((value) => value !== TestStatus.Pass);
 export function isNonPassingTestStatus(status: TestStatus): boolean {
-    return [TestStatus.Fail, TestStatus.Error, TestStatus.Skipped].includes(status);
+    return nonPassing.includes(status);
 }
 
 export type TestResult = {

Original file line number	Diff line number	Diff line change
`@@ -96,8 +96,9 @@ export enum TestStatus {`
`96`	`96`	`export type FinalTestStatus = TestStatus.Fail \| TestStatus.Error \| TestStatus.Skipped \| TestStatus.Pass;`
`97`	`97`	`export type NonPassingTestStatus = Exclude<FinalTestStatus, TestStatus.Pass>;`
`98`	`98`
	`99`	`+const nonPassing = Object.values(TestStatus).filter((value) => value !== TestStatus.Pass);`
`99`	`100`	`export function isNonPassingTestStatus(status: TestStatus): boolean {`
`100`		`- return [TestStatus.Fail, TestStatus.Error, TestStatus.Skipped].includes(status);`
	`101`	`+ return nonPassing.includes(status);`
`101`	`102`	`}`
`102`	`103`
`103`	`104`	`export type TestResult = {`