Put debugger data viewer integration behind an experiment

[joyceerhl]

• Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
• Title summarizes what is changing.
• Has a news entry file (remember to thank yourself!).
• Appropriate comments and documentation strings in the code.
• Has sufficient logging.
• Has telemetry for enhancements.
• Unit tests & system/integration tests are added/updated.
• Test plan is updated as appropriate.
• package-lock.json has been regenerated by running npm install (if dependencies have changed).
• The wiki is updated with any design decisions/details.

[codecov-io]

Codecov Report

Merging #14460 into release-2020.10 will decrease coverage by 0.02%.
The diff coverage is 54.16%.

@@                 Coverage Diff                 @@
##           release-2020.10   #14460      +/-   ##
===================================================
- Coverage            59.19%   59.17%   -0.03%     
===================================================
  Files                  720      721       +1     
  Lines                40211    40228      +17     
  Branches              5828     5828              
===================================================
+ Hits                 23802    23803       +1     
- Misses               15147    15160      +13     
- Partials              1262     1265       +3     

Impacted Files	Coverage Δ
...ience/interactive-common/interactiveWindowTypes.ts	100.00% <ø> (ø)
src/client/telemetry/index.ts	80.41% <ø> (ø)
src/client/datascience/commands/commandRegistry.ts	34.76% <25.00%> (+0.23%)	⬆️
...ata-viewing/debuggerDataViewerExperimentEnabler.ts	42.85% <42.85%> (ø)
src/client/common/serviceRegistry.ts	100.00% <100.00%> (ø)
src/client/datascience/constants.ts	99.78% <100.00%> (-0.01%)	⬇️
src/client/telemetry/constants.ts	100.00% <100.00%> (ø)
...very/locators/services/virtualenvwrapperLocator.ts	76.92% <0.00%> (-15.39%)	⬇️
src/client/common/utils/platform.ts	60.00% <0.00%> (-8.00%)	⬇️
.../pythonEnvironments/common/externalDependencies.ts	64.10% <0.00%> (-2.57%)	⬇️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2971ac5...c081403. Read the comment docs.

[IanMatthewHuff]

Is this for the October release? Because the myNoDS PR is going to trash these changes when it hits.

[joyceerhl]

@IanMatthewHuff yeah this is for October. Maybe this should be going straight into the release branch then, since I'm going to rework the integration for November?

[IanMatthewHuff]

@IanMatthewHuff yeah this is for October. Maybe this should be going straight into the release branch then, since I'm going to rework the integration for November?

I think that might be the smart approach to take, good thought on going directly to release. Otherwise this will just cause merge issues for the myNoDS change.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

[joyceerhl]

@DonJayamanne I believe I've addressed your comment on this PR!

[karthiknadig]

@joyceerhl we need the Compiler fix in master. Insiders is currently not getting pushed out because of it.

[joyceerhl]

@karthiknadig Will port it over, thanks!

[codecov-commenter]

Codecov Report

❌ Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 59%. Comparing base (2971ac5) to head (c081403).

Files with missing lines	Patch %	Lines
...ata-viewing/debuggerDataViewerExperimentEnabler.ts	42%	8 Missing ⚠️
src/client/datascience/commands/commandRegistry.ts	25%	3 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           release-2020.10   #14460   +/-   ##
================================================
- Coverage               59%      59%   -1%     
================================================
  Files                  720      721    +1     
  Lines                40211    40228   +17     
  Branches              5828     5828           
================================================
+ Hits                 23802    23811    +9     
- Misses               15147    15155    +8     
  Partials              1262     1262           

Files with missing lines	Coverage Δ
src/client/common/serviceRegistry.ts	100% <100%> (ø)
src/client/datascience/constants.ts	99% <100%> (-1%)	⬇️
...ience/interactive-common/interactiveWindowTypes.ts	100% <ø> (ø)
src/client/telemetry/constants.ts	100% <100%> (ø)
src/client/telemetry/index.ts	80% <ø> (ø)
src/client/datascience/commands/commandRegistry.ts	34% <25%> (+<1%)	⬆️
...ata-viewing/debuggerDataViewerExperimentEnabler.ts	42% <42%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.