Skip to content

Cherry pick "Bind function to correct this for workspace syms"#14743

Merged
jakebailey merged 1 commit intomicrosoft:release-2020.11from
jakebailey:cherry-pick-3
Nov 16, 2020
Merged

Cherry pick "Bind function to correct this for workspace syms"#14743
jakebailey merged 1 commit intomicrosoft:release-2020.11from
jakebailey:cherry-pick-3

Conversation

@jakebailey
Copy link
Copy Markdown
Member

For #14727
Cherry picks #14728

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #14743 (d005f60) into release-2020.11 (ab63f02) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2020.11   #14743      +/-   ##
===================================================
- Coverage            65.01%   65.01%   -0.01%     
===================================================
  Files                  543      543              
  Lines                25429    25429              
  Branches              3593     3593              
===================================================
- Hits                 16533    16532       -1     
- Misses                8219     8220       +1     
  Partials               677      677              
Impacted Files Coverage Δ
.../jupyter/languageserver/notebookMiddlewareAddon.ts 3.84% <0.00%> (ø)
src/client/common/utils/platform.ts 68.00% <0.00%> (-4.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab63f02...d005f60. Read the comment docs.

@jakebailey jakebailey merged commit 171ffd0 into microsoft:release-2020.11 Nov 16, 2020
@jakebailey jakebailey deleted the cherry-pick-3 branch November 16, 2020 19:42
karthiknadig added a commit that referenced this pull request Nov 26, 2020
* Cherry pick from main (#14644)

* Update shipped wheels version (#14615)

* Update shipped wheels version

* News item

* Remove redundant files (#14620)

* Add extension dependencies at build time (#14636)

* Use Node 12.15 in Insiders and Release GitHub Actions (#14641)

* Use Node 12.15 on all Insiders and Release GitHub Actions jobs (#14642)

Co-authored-by: Joyce Er <[email protected]>

* Cherry pic fixes into release for tests. (#14673)

* Added FSWatching base class and made related changes (#14605)

* Add FSWatching locator base class

* Correct glob pattern to not match python3.2whoa

* Add documentation of python binary watcher

* Fix lint errors

* Update ignore list

* Add disposable registry

* Modify FSWatching Locator

* Code reviews

* Use string[]

* Remove list disposable getter

* Fix failing global virtual env watcher tests (#14633)

Co-authored-by: Kartik Raj <[email protected]>

* Version, change log and cherrypicks for nov release (#14696)

* change log updates

* Update gifs

* Fix for interpreter selection (#14693)

* Fix for interpreter selection

* Fix linting errors

* Minor tweak to property removal

* Cherry pick "Bind function to correct this for workspace syms" (#14743)

* Fix #14674: Enable overriding "pythonPath" in the launcher

Fix #12462: Update launch.json schema to add "python" and remove "pythonPath"

Split the "pythonPath" debug property into "python", "debugAdapterPython", and "debugLauncherPython".

Do most debug config validation on fully expanded property values via resolveDebugConfigurationWithSubstitutedVariables().

Add fixups for legacy launch.json with "pythonPath".

* Point release change log and version update (#14750)

* Point release change log and version update

* Fix process picker (#14700)

* Workaround VSCode bug for process picker

* Fix how we pass in icons to VSCode

* update change log with cherry pick

Co-authored-by: Kartik Raj <[email protected]>

Co-authored-by: Joyce Er <[email protected]>
Co-authored-by: Kartik Raj <[email protected]>
Co-authored-by: Jake Bailey <[email protected]>
Co-authored-by: Pavel Minaev <[email protected]>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65%. Comparing base (ab63f02) to head (d005f60).

Files with missing lines Patch % Lines
.../jupyter/languageserver/notebookMiddlewareAddon.ts 0% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-2020.11   #14743   +/-   ##
================================================
- Coverage               65%      65%   -1%     
================================================
  Files                  543      543           
  Lines                25429    25429           
  Branches              3593     3593           
================================================
- Hits                 16533    16532    -1     
- Misses                8219     8220    +1     
  Partials               677      677           
Files with missing lines Coverage Δ
.../jupyter/languageserver/notebookMiddlewareAddon.ts 3% <0%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants