chore: refactor vitest usage, ts config, shuffle dependencies#1540
chore: refactor vitest usage, ts config, shuffle dependencies#1540josefaidt wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
|
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
|
ah this is failing because the module resolution is set to NodeNext instead of bundler, but I'll cover that in a separate PR with an adjustment to the tsconfig usage and sharing |
felixweinberger
left a comment
There was a problem hiding this comment.
Looks like this is blocked on a tsconfig change, is that something you're still planning on submitting? Otherwise would close this PR for the time being (doing a pass through the backlog atm)
|
Hey @felixweinberger thanks for taking a look. I can put something up later this week most likely but feel free to close in the meantime. With the TypeScript v6 announcement and the changes to the |
Motivation and Context
ref #1537, item 2 and 12
The vitest setup can benefit from exporting the TypeScript-based config directly, and consumed with type-safety in consuming packages. This PR:
vitest.config.jstovitest.config.tsmainexport pointing tovitest.config.mjsin shared packagevitest/globalsfrom shared tsconfig -- overriding TypeScript's default type resolution behaviorenv.d.tsin each consuming package (this can also be made more specific to just the tests by creating a separate tsconfig for test files, that way vitest/globals aren't polluting the global namespace of source files -- happy to make this adjustment)vitestfrom the root package.json as it is unneededHow Has This Been Tested?
re-ran
pnpm test:allto ensure tests are still running and completing successfullyBreaking Changes
Types of changes
Checklist
Additional context