change reflection upon review

Author: lorenzo132

cogs/utility.py

@@ -1467,25 +1467,38 @@ async def permissions_override(self, ctx, command_name: str.lower, *, level_name
         return await ctx.send(embed=embed)
 
     async def _bulk_override_flow(self, ctx):
-        await ctx.send(
-            "Please list the commands you want to override. "
-            "You can list multiple commands separated by spaces or newlines.\n"
-            "Example: `ban, kick, mod`."
+        embed = discord.Embed(
+            title="Bulk Override",
+            description=(
+                "Please list the commands you want to override. "
+                "You can list multiple commands separated by spaces or newlines.\n"
+                "Example: `reply, block, unblock`."
+            ),
+            color=self.bot.main_color,
         )
+        await ctx.send(embed=embed)
 
         try:
             msg = await self.bot.wait_for(
                 "message",
                 check=lambda m: m.author == ctx.author and m.channel == ctx.channel,
                 timeout=120.0,
             )
+
         except asyncio.TimeoutError:
-            return await ctx.send("Timed out.")
+            return await ctx.send(embed=discord.Embed(title="Error", description="Timed out.", color=self.bot.error_color))
 
         raw_commands = msg.content.replace(",", " ").replace("\n", " ").split(" ")
         # Filter empty strings from split
         raw_commands = [c for c in raw_commands if c.strip()]
 
+        if self.bot.prefix:
+            # Strip prefix from commands if present
+            raw_commands = [
+                c[len(self.bot.prefix) :] if c.startswith(self.bot.prefix) else c
+                for c in raw_commands
+            ]
+
         found_commands = []
         invalid_commands = []
 
@@ -1511,12 +1524,22 @@ async def _bulk_override_flow(self, ctx):
                     timeout=60.0,
                 )
                 if msg.content.lower() not in ("y", "yes"):
-                    return await ctx.send("Aborted.")
+                    return await ctx.send(
+                        embed=discord.Embed(
+                            title="Operation Aborted",
+                            description="No changes have been applied.",
+                            color=self.bot.error_color,
+                        )
+                    )
             except asyncio.TimeoutError:
-                return await ctx.send("Timed out.")
+                return await ctx.send(embed=discord.Embed(title="Error", description="Timed out.", color=self.bot.error_color))
 
         if not found_commands:
-            return await ctx.send("No valid commands provided. Aborting.")
+            return await ctx.send(
+                embed=discord.Embed(
+                    title="Error", description="No valid commands provided. Aborting.", color=self.bot.error_color
+                )
+            )
 
         # Expand subcommands
         final_commands = set()
@@ -1530,24 +1553,36 @@ def add_command_recursive(cmd):
         for cmd in found_commands:
             add_command_recursive(cmd)
 
-        await ctx.send(
-            f"Found {len(final_commands)} commands (including subcommands).\n"
-            "What permission level should these commands be set to? (e.g. `Owner`, `Admin`, `Moderator`, `Supporter`, `User`)"
+        embed = discord.Embed(
+            title="Select Permission Level",
+            description=(
+                f"Found {len(final_commands)} commands (including subcommands).\n"
+                "What permission level should these commands be set to? (e.g. `Owner`, `Admin`, `Moderator`, `Supporter`, `User`)"
+            ),
+            color=self.bot.main_color,
         )
+        await ctx.send(embed=embed)
 
         try:
             msg = await self.bot.wait_for(
                 "message",
                 check=lambda m: m.author == ctx.author and m.channel == ctx.channel,
                 timeout=60.0,
             )
+
         except asyncio.TimeoutError:
-            return await ctx.send("Timed out.")
+            return await ctx.send(embed=discord.Embed(title="Error", description="Timed out.", color=self.bot.error_color))
 
         level_name = msg.content
         level = self._parse_level(level_name)
         if level == PermissionLevel.INVALID:
-            return await ctx.send(f"Invalid permission level: `{level_name}`. Aborting.")
+            return await ctx.send(
+                embed=discord.Embed(
+                    title="Error",
+                    description=f"Invalid permission level: `{level_name}`. Aborting.",
+                    color=self.bot.error_color,
+                )
+            )
 
         # Confirmation
         command_list_str = ", ".join(
@@ -1575,10 +1610,20 @@ def add_command_recursive(cmd):
                 timeout=30.0,
             )
         except asyncio.TimeoutError:
-            return await ctx.send("Timed out. No changes applied.")
+            return await ctx.send(
+                embed=discord.Embed(
+                    title="Error", description="Timed out. No changes applied.", color=self.bot.error_color
+                )
+            )
 
         if msg.content.lower() == "cancel":
-            return await ctx.send("Aborted.")
+            return await ctx.send(
+                embed=discord.Embed(
+                    title="Operation Aborted",
+                    description="No changes have been applied.",
+                    color=self.bot.error_color,
+                )
+            )
 
         # Apply changes
         count = 0
@@ -1588,7 +1633,13 @@ def add_command_recursive(cmd):
 
         await self.bot.config.update()
 
-        await ctx.send(f"Successfully updated permissions for {count} commands.")
+        await ctx.send(
+            embed=discord.Embed(
+                title="Success",
+                description=f"Successfully updated permissions for {count} commands.",
+                color=self.bot.main_color,
+            )
+        )
 
     @permissions.command(name="add", usage="[command/level] [name] [user/role]")
     @checks.has_permissions(PermissionLevel.OWNER)