Skip to content

Commit 054d83a

Browse files
committed
Address review feedback
1 parent 176192b commit 054d83a

2 files changed

Lines changed: 4 additions & 8 deletions

File tree

doc/changelog.rst

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,10 @@ PyMongo 4.17 brings a number of changes including:
88

99
- Remove unused validation functions from pymongo/common.py
1010

11-
- validate_positive_integer_or_none (line 236) — superseded by
12-
validate_non_negative_integer_or_none which is used
13-
- validate_int_or_basestring (line 264) — a variant of
14-
validate_non_negative_int_or_basestring which is used
15-
- validate_auth_option (line 823) — validates auth mechanism properties but
16-
is never invoked
11+
- ``validate_positive_integer_or_none`` (internal helper, no longer used)
12+
- ``validate_int_or_basestring`` (internal helper, no longer used)
13+
- ``validate_auth_option`` (validated auth mechanism properties but was never
14+
used)
1715

1816
- Added the :meth:`~pymongo.asynchronous.client_session.AsyncClientSession.bind` and :meth:`~pymongo.client_session.ClientSession.bind` methods
1917
that allow users to bind a session to all database operations within the scope of a context manager instead of having to explicitly pass the session to each individual operation.

pymongo/common.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -796,8 +796,6 @@ def validate_server_monitoring_mode(option: str, value: str) -> str:
796796
"waitqueuetimeoutms",
797797
]
798798

799-
_AUTH_OPTIONS = frozenset(["authmechanismproperties"])
800-
801799

802800
def _get_validator(
803801
key: str, validators: dict[str, Callable[[Any, Any], Any]], normed_key: Optional[str] = None

0 commit comments

Comments
 (0)