Fix: Secret input field texts were bleeding under obscure toggle button#461
Merged
Conversation
This reverts commit 92c252e.
gschier
approved these changes
May 21, 2026
Member
gschier
left a comment
gschier
left a comment
There was a problem hiding this comment.
Thanks for the report! Changed to a more stable fix, which addressed it on my end. Please report back if this one doesn't work on your end (hard to reproduce exactly)
Contributor
Author
|
Thank you for reviewing this. Sadly your change doesn't solve it for me. However my change pr-1.5 solves it, i couldn't figure out a more robust solution like yours. I'm on MacOS so maybe its a webkit problem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In secret input fields (e.g. Bearer token, API key), the masked text would visually bleed into the obscure/reveal toggle button due to insufficient right-side padding on the editor. Added pr-1.5 to the editor's className in BaseInput to push text content away from the button, matching the padding already applied in EncryptionInput (used by JWT Bearer, where the issue was not present).
Submission
CONTRIBUTING.md.Approved feedback item (required if not a bug fix or small-scope improvement):
Related