Update articles#5828
Open
Srihari2222 wants to merge 6 commits into
Open
Conversation
Comment on lines
+599
to
+604
| nums[i++] = num; | ||
| count.set(num, cnt - 1); | ||
| if (count.get(num)! >= 1) { | ||
| nums[i++] = num; | ||
| count.set(num, cnt - 1); | ||
| } |
There was a problem hiding this comment.
🟢 Low articles/remove-duplicates-from-sorted-array-ii.md:599
The second count.set(num, cnt - 1) on line 603 uses the original destructured cnt instead of decrementing the already-decremented value, so it sets the count back to cnt - 1 instead of cnt - 2. This contradicts the Rust version which correctly decrements twice, and misrepresents the algorithm's logic in an educational article. Consider changing to count.set(num, cnt - 2) to correctly reflect the double-decrement.
Suggested change
| nums[i++] = num; | |
| count.set(num, cnt - 1); | |
| if (count.get(num)! >= 1) { | |
| nums[i++] = num; | |
| count.set(num, cnt - 1); | |
| } | |
| count.set(num, cnt - 1); | |
| if (count.get(num)! >= 1) { | |
| nums[i++] = num; | |
| count.set(num, cnt - 2); | |
| } |
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file articles/remove-duplicates-from-sorted-array-ii.md around lines 599-604:
The second `count.set(num, cnt - 1)` on line 603 uses the original destructured `cnt` instead of decrementing the already-decremented value, so it sets the count back to `cnt - 1` instead of `cnt - 2`. This contradicts the Rust version which correctly decrements twice, and misrepresents the algorithm's logic in an educational article. Consider changing to `count.set(num, cnt - 2)` to correctly reflect the double-decrement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TypeScript and C# implementations to six algorithm articles
Adds TypeScript code snippets to six articles covering array and string problems, and adds C# snippets to the time-needed-to-buy-tickets article. Each new snippet mirrors the existing Rust implementations for the same approach (brute force, prefix sum, two pointers, etc.), using idiomatic JS/TS or C# data structures.
Macroscope summarized 9a9c53b.