Skip to content

Commit 7bfa679

Browse files
wip
Signed-off-by: tobiasKaminsky <[email protected]>
1 parent 3cec8d6 commit 7bfa679

8 files changed

Lines changed: 5 additions & 18 deletions

File tree

app/src/androidTest/java/com/nextcloud/ui/SetOnlineStatusBottomSheetIT.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ class SetOnlineStatusBottomSheetIT : AbstractIT() {
2828

2929
@get:Rule
3030
val permissionRule: GrantPermissionRule = GrantPermissionRule.grant(
31-
Manifest.permission.WRITE_EXTERNAL_STORAGE,
3231
Manifest.permission.POST_NOTIFICATIONS
3332
)
3433

app/src/androidTest/java/com/nextcloud/ui/SetStatusMessageBottomSheetIT.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import org.junit.Test
2727
class SetStatusMessageBottomSheetIT : AbstractIT() {
2828
@get:Rule
2929
val permissionRule: GrantPermissionRule = GrantPermissionRule.grant(
30-
Manifest.permission.WRITE_EXTERNAL_STORAGE,
3130
Manifest.permission.POST_NOTIFICATIONS
3231
)
3332

app/src/androidTest/java/com/owncloud/android/AbstractIT.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import com.nextcloud.client.preferences.AppPreferencesImpl;
3535
import com.nextcloud.client.preferences.DarkMode;
3636
import com.nextcloud.common.NextcloudClient;
37+
import com.nextcloud.test.GrantStoragePermissionRule;
3738
import com.nextcloud.test.RandomStringGenerator;
3839
import com.owncloud.android.datamodel.ArbitraryDataProvider;
3940
import com.owncloud.android.datamodel.ArbitraryDataProviderImpl;
@@ -58,6 +59,8 @@
5859
import org.junit.After;
5960
import org.junit.Before;
6061
import org.junit.BeforeClass;
62+
import org.junit.Rule;
63+
import org.junit.rules.TestRule;
6164

6265
import java.io.File;
6366
import java.io.FileWriter;
@@ -87,8 +90,8 @@
8790
* Common base for all integration tests.
8891
*/
8992
public abstract class AbstractIT {
90-
// @Rule
91-
// public final TestRule storagePermissionRule = GrantStoragePermissionRule.grant();
93+
@Rule
94+
public final TestRule storagePermissionRule = GrantStoragePermissionRule.grant();
9295

9396
// @Rule
9497
// public GrantPermissionRule notificationsPermissionRule = GrantPermissionRule.grant(Manifest.permission.POST_NOTIFICATIONS);

app/src/androidTest/java/com/owncloud/android/ScreenshotsIT.kt

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
*/
77
package com.owncloud.android
88

9-
import android.Manifest
109
import androidx.test.core.app.launchActivity
1110
import androidx.test.espresso.Espresso
1211
import androidx.test.espresso.Espresso.onView
@@ -18,7 +17,6 @@ import androidx.test.espresso.matcher.ViewMatchers.isDisplayed
1817
import androidx.test.espresso.matcher.ViewMatchers.isRoot
1918
import androidx.test.espresso.matcher.ViewMatchers.withId
2019
import androidx.test.espresso.matcher.ViewMatchers.withText
21-
import androidx.test.rule.GrantPermissionRule
2220
import com.owncloud.android.datamodel.OCFile
2321
import com.owncloud.android.ui.activity.FileDisplayActivity
2422
import com.owncloud.android.ui.activity.SettingsActivity
@@ -27,20 +25,12 @@ import com.owncloud.android.utils.ScreenshotTest
2725
import org.junit.Assert.assertTrue
2826
import org.junit.BeforeClass
2927
import org.junit.ClassRule
30-
import org.junit.Rule
3128
import org.junit.Test
3229
import tools.fastlane.screengrab.Screengrab
3330
import tools.fastlane.screengrab.UiAutomatorScreenshotStrategy
3431
import tools.fastlane.screengrab.locale.LocaleTestRule
3532

3633
class ScreenshotsIT : AbstractIT() {
37-
38-
@get:Rule
39-
val permissionRule: GrantPermissionRule = GrantPermissionRule.grant(
40-
Manifest.permission.WRITE_EXTERNAL_STORAGE,
41-
Manifest.permission.POST_NOTIFICATIONS
42-
)
43-
4434
@Test
4535
@ScreenshotTest
4636
fun gridViewScreenshot() {

app/src/androidTest/java/com/owncloud/android/ui/activity/DrawerActivityIT.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ class DrawerActivityIT : AbstractIT() {
4040

4141
@get:Rule
4242
val permissionRule: GrantPermissionRule = GrantPermissionRule.grant(
43-
Manifest.permission.WRITE_EXTERNAL_STORAGE,
4443
Manifest.permission.POST_NOTIFICATIONS
4544
)
4645

app/src/androidTest/java/com/owncloud/android/ui/dialog/DialogFragmentIT.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ class DialogFragmentIT : AbstractIT() {
8888

8989
@get:Rule
9090
val permissionRule: GrantPermissionRule = GrantPermissionRule.grant(
91-
Manifest.permission.WRITE_EXTERNAL_STORAGE,
9291
Manifest.permission.POST_NOTIFICATIONS
9392
)
9493

app/src/androidTest/java/com/owncloud/android/ui/dialog/SyncFileNotEnoughSpaceDialogFragmentTest.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ class SyncFileNotEnoughSpaceDialogFragmentTest : AbstractIT() {
2626

2727
@get:Rule
2828
val permissionRule: GrantPermissionRule = GrantPermissionRule.grant(
29-
Manifest.permission.WRITE_EXTERNAL_STORAGE,
3029
Manifest.permission.POST_NOTIFICATIONS
3130
)
3231

app/src/androidTest/java/com/owncloud/android/ui/preview/PreviewTextFileFragmentTest.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ class PreviewTextFileFragmentTest : AbstractIT() {
2727

2828
@get:Rule
2929
val permissionRule: GrantPermissionRule = GrantPermissionRule.grant(
30-
Manifest.permission.WRITE_EXTERNAL_STORAGE,
3130
Manifest.permission.POST_NOTIFICATIONS
3231
)
3332

0 commit comments

Comments
 (0)