Selecting images from Media causes crash

[kerim-yagmurcu]

⚠️ Before posting ⚠️

• This is a bug, not a question or an enhancement.
• I've searched for similar issues and didn't find a duplicate.
• I've written a clear and descriptive title for this issue, not just "Bug" or "Crash".
• I agree to follow Nextcloud's Code of Conduct.

Steps to reproduce

I was selecting images from the Media tab, then the App crashed.

Expected behaviour

I Expected to be able to select many images without the app crashing

Actual behaviour

The App Crashes when I select many images

Android version

Latest

Device brand and model

Samsung Galaxy S25 Ultra

Stock or custom OS?

Stock

Nextcloud android app version

Latest

Nextcloud server version

Latest

Using a reverse proxy?

No

Android logs

No response

Server error logs

Additional information

No response

[beingkha3]

Facing same Issue. Getting app crash for nextcloud app on android when I try to select multiple images.

Here the app crash logs:

java.lang.IllegalStateException: Two different ViewHolders have the same stable ID. Stable IDs in your adapter MUST BE unique and SHOULD NOT change. ViewHolder 1:GalleryRowHolder{2d7eece position=2 id=867465, oldPos=-1, pLpos:-1 not recyclable(1)} View Holder 2:GalleryRowHolder{9665abc position=1 id=867465, oldPos=-1, pLpos:-1} com.owncloud.android.ui.EmptyRecyclerView{7a54785 VFED..... ......ID 0,0-1220,2315 #7f0a02f3 app:id/list_root}, adapter:com.owncloud.android.ui.adapter.GalleryAdapter@891093c, layout:androidx.recyclerview.widget.GridLayoutManager@30829da, context:com.owncloud.android.ui.activity.FileDisplayActivity@bd3e04c at androidx.recyclerview.widget.RecyclerView.handleMissingPreInfoForChangeError(RecyclerView.java:4778) at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep3(RecyclerView.java:4702) at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:4367) at androidx.recyclerview.widget.RecyclerView.consumePendingUpdateOperations(RecyclerView.java:2095) at androidx.recyclerview.widget.RecyclerView$1.run(RecyclerView.java:468) at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2040) at android.view.Choreographer$CallbackRecord.run(Choreographer.java:2049) at android.view.Choreographer.doCallbacks(Choreographer.java:1524) at android.view.Choreographer.doFrame(Choreographer.java:1381) at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:2003) at android.os.Handler.handleCallback(Handler.java:995) at android.os.Handler.dispatchMessage(Handler.java:103) at android.os.Looper.loopOnce(Looper.java:267) at android.os.Looper.loop(Looper.java:360) at android.app.ActivityThread.main(ActivityThread.java:10054) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:616) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1115)

The crash is thrown by Android’s RecyclerView while laying out a grid:
IllegalStateException: Two different ViewHolders have the same stable ID

[camillo-positano]

Hello,

I am currently investigating the issue to see if I can replicate it on my end.

During my analysis, I noticed that the error might be caused by duplicate files within the image list. In my test environment, where there are no duplicates, the issue does not occur.

Could you please check if there are any duplicate pictures in your specific case?

Tanks
Camillo 😄

[beingkha3]

Hello,

I am currently investigating the issue to see if I can replicate it on my end.

During my analysis, I noticed that the error might be caused by duplicate files within the image list. In my test environment, where there are no duplicates, the issue does not occur.

Could you please check if there are any duplicate pictures in your specific case?

Tanks
Camillo 😄

Hi,
I confirm that there are no duplicates in my media list as of when selecting multiple images in the media list.

[camillo-positano]

Thanks for the additional details!

1. Does the crash occur in both scenarios: with no filters applied and when filtering specifically for photos/videos?
2. Could you try to reproduce the crash by selecting only one media type at a time (e.g., photos only, then videos only)? If it crashes, please check if the behaviour changes when the corresponding filter is applied.

Let me know if I need to be clearer with the instructions

Camillo 😄

[beingkha3]

Thanks for the additional details!

1. Does the crash occur in both scenarios: with no filters applied and when filtering specifically for photos/videos?
2. Could you try to reproduce the crash by selecting only one media type at a time (e.g., photos only, then videos only)? If it crashes, please check if the behaviour changes when the corresponding filter is applied.

Let me know if I need to be clearer with the instructions

Camillo 😄

1. Crashes When selecting photo, when no filters are applied and also when filter applied to display only images.

2. When selected only one media type i.e. images the crash occurs. When selecting video media type, the crash doesn't occur.

[PhilLab]

The viewholderid computation was changed in #15919. So this issue is likely a duplicate of #15918 and fixed since release 3.35.1.

For additional context, #16267 dug deeper into the issue, adding a test, and proving that the bug was essentially a hash collision caused by an improper hash computation for unique view ID generation.

Closing this, but please reopen if you can still reproduce with version >= 3.35.1