Skip to content

Commit 1f06b0f

Browse files
committed
fix default role
1 parent 8554afa commit 1f06b0f

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

src/db.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
export async function addNewContributors(
88
db: Database,
99
contributors: string[],
10-
role: string | null = null,
10+
role: string,
1111
) {
1212
// Remove duplicates from the array
1313
contributors = [...new Set(contributors)];
@@ -36,7 +36,7 @@ export async function addNewContributors(
3636
export async function updateBotRoles(
3737
db: Database,
3838
botUsernames: string[],
39-
logger: Logger
39+
logger: Logger,
4040
) {
4141
if (botUsernames.length === 0) {
4242
logger.info("No bot users to update");
@@ -53,7 +53,7 @@ export async function updateBotRoles(
5353
SET role = 'bot'
5454
WHERE username = ?;
5555
`,
56-
[username]
56+
[username],
5757
);
5858

5959
logger.info(`Updated ${result.rowsAffected} bot contributors`);

src/get-activities.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -934,7 +934,7 @@ async function persistRepoActivities(
934934
db: PluginContext["db"],
935935
activities: Activity[],
936936
logger: Logger,
937-
defaultRole: string | null,
937+
defaultRole: string,
938938
): Promise<number> {
939939
const contributorUsernames = activities.map((a) => a.contributor);
940940
await addNewContributors(db, contributorUsernames, defaultRole);
@@ -1052,7 +1052,9 @@ export async function getActivities({ db, config, logger }: PluginContext) {
10521052
).filter((a) => !disabledSlugs.has(a.activity_definition));
10531053

10541054
const defaultRole =
1055-
typeof config.defaultRole === "string" ? config.defaultRole : null;
1055+
typeof config.defaultRole === "string"
1056+
? config.defaultRole
1057+
: "contributor";
10561058

10571059
const saved = await persistRepoActivities(
10581060
db,

0 commit comments

Comments
 (0)