mqtt: removing redundant virtualization

Author: viacheslauK

mqtt_streaming_module/include/mqtt_streaming_module/mqtt_base_fb.h

@@ -67,17 +67,16 @@ class MqttBaseFb : public FunctionBlock
     StatusHelper<SubscriptionStatus> subscriptionStatus;
     int qos = DEFAULT_SUB_QOS;
 
-    virtual void createSignals() = 0;
     virtual void processMessage(const mqtt::MqttMessage& msg) = 0;
 
-    virtual void initProperties(const PropertyObjectPtr& config);
+    void initProperties(const PropertyObjectPtr& config);
     virtual void readProperties() = 0;
 
     void onSignalsMessage(const mqtt::MqttAsyncClient& subscriber, const mqtt::MqttMessage& msg);
 
     virtual void clearSubscribedTopic() = 0;
-    virtual  CmdResult subscribeToTopic();
-    virtual  CmdResult unsubscribeFromTopic();
+    CmdResult subscribeToTopic();
+    CmdResult unsubscribeFromTopic();
 
     virtual void propertyChanged() = 0;
 

mqtt_streaming_module/include/mqtt_streaming_module/mqtt_json_receiver_fb_impl.h

@@ -53,11 +53,11 @@ class MqttJsonReceiverFbImpl final : public MqttBaseFb
 
     void initNestedFbTypes();
 
-    void createSignals() override;
+    void createSignals();
     void clearSubscribedTopic() override;
 
     void processMessage(const mqtt::MqttMessage& msg) override;
-    void initProperties(const PropertyObjectPtr& config) override;
+    void initProperties(const PropertyObjectPtr& config);
     void readProperties() override;
     void readJsonConfig();
     std::pair<bool, std::string> readFileToString(const std::string& filePath);

mqtt_streaming_module/include/mqtt_streaming_module/mqtt_raw_receiver_fb_impl.h

@@ -45,7 +45,7 @@ class MqttRawReceiverFbImpl final : public MqttBaseFb
 
     static std::string generateLocalId();
 
-    void createSignals() override;
+    void createSignals();
     void clearSubscribedTopic() override;
 
     void processMessage(const mqtt::MqttMessage& msg) override;