Continue fixing and breaking things..

Author: franzpoeschel

include/openPMD/IO/AbstractIOHandler.hpp

@@ -182,6 +182,7 @@ namespace internal
      * To be used for reading
      */
     FlushParams const defaultFlushParams{};
+    FlushParams const publicFlush{FlushLevel::UserFlush};
 
     struct ParsedFlushParams;
 

include/openPMD/Series.hpp

@@ -905,7 +905,7 @@ OPENPMD_private
         iterations_iterator end,
         internal::FlushParams const &flushParams,
         bool flushIOHandler = true);
-    void flushRankTable();
+    void flushRankTable(FlushLevel);
     /* Parameter `read_only_this_single_iteration` used for reopening an
      * Iteration after closing it.
      */

src/Iteration.cpp

@@ -302,7 +302,7 @@ void Iteration::flushFileBased(
         s.get()
             .m_rankTable.m_attributable.get()
             .m_writable.abstractFilePosition.reset();
-        s.flushRankTable();
+        s.flushRankTable(flushParams.flushLevel);
 
         /* create basePath */
         Parameter<Operation::CREATE_PATH> pCreate;

src/Series.cpp

@@ -405,7 +405,7 @@ chunk_assignment::RankMeta Series::rankTable([[maybe_unused]] bool collective)
         readDataset.data = get;
 
         IOHandler()->enqueue(IOTask(&rankTable.m_attributable, readDataset));
-        IOHandler()->flush(internal::defaultFlushParams);
+        IOHandler()->flush(internal::publicFlush);
     };
 
 #if openPMD_HAVE_MPI
@@ -464,8 +464,12 @@ Series &Series::setRankTable(const std::string &myRankInfo)
     return *this;
 }
 
-void Series::flushRankTable()
+void Series::flushRankTable(FlushLevel l)
 {
+    if (!flush_level::global_flushpoint(l))
+    {
+        return;
+    }
     auto &series = get();
     auto &rankTable = series.m_rankTable;
     auto maybeMyRankInfo = std::visit(
@@ -1629,7 +1633,7 @@ void Series::flushGorVBased(
             fCreate.name = series.m_name;
             IOHandler()->enqueue(IOTask(this, fCreate));
 
-            flushRankTable();
+            flushRankTable(flushParams.flushLevel);
         }
 
         series.iterations.flush(

test/SerialIOTest.cpp

@@ -1972,6 +1972,10 @@ inline void fileBased_write_test(const std::string &backend)
                 "\\",
                 "/"));
 
+        // TODO: somehow make the rank table appear in iteration 1
+        o.iterations[1];
+        o.flush();
+
         ParticleSpecies &e_1 = o.iterations[1].particles["e"];
 
         std::vector<double> position_global(4);