Fixes

Author: franzpoeschel

include/openPMD/backend/BaseRecord.hpp

@@ -366,9 +366,6 @@ class BaseRecord
      */
     bool scalar() const;
 
-protected:
-    void readBase();
-
 private:
     void flush(std::string const &, internal::FlushParams const &) final;
     virtual void

include/openPMD/backend/ScientificDefaults_internal.hpp

@@ -239,8 +239,8 @@ struct ConfigAttribute
         Attribute attribute(Attribute::from_any, std::move(*aRead.m_resource));
         if (attributeReaders.empty())
         {
-            std::cout << "Empty attribute readers for " << this->attrName
-                      << std::endl;
+            // No readers emplaced for this attribute
+            return;
         }
         for (auto &attributeReader : attributeReaders)
         {

src/Mesh.cpp

@@ -489,7 +489,7 @@ void Mesh::read()
 
     std::move(homogenizeExtents).homogenize(*this);
 
-    readBase();
+    internal::ScientificDefaults<Mesh>::readDefaults(IOHandler()->m_standard);
 
     readAttributes(ReadMode::FullyReread);
 }

src/Record.cpp

@@ -24,6 +24,7 @@
 #include "openPMD/ThrowError.hpp"
 #include "openPMD/UnitDimension.hpp"
 #include "openPMD/backend/BaseRecord.hpp"
+#include "openPMD/backend/ScientificDefaults.hpp"
 
 #include <iostream>
 
@@ -191,7 +192,7 @@ auto Record::read() -> internal::HomogenizeExtents
         }
     }
 
-    readBase();
+    internal::ScientificDefaults<Record>::readDefaults(IOHandler()->m_standard);
 
     readAttributes(ReadMode::FullyReread);
     return res;

src/RecordComponent.cpp

@@ -29,6 +29,7 @@
 #include "openPMD/auxiliary/StringManip.hpp"
 #include "openPMD/backend/Attributable.hpp"
 #include "openPMD/backend/BaseRecord.hpp"
+#include "openPMD/backend/ScientificDefaults.hpp"
 #include "openPMD/backend/Variant_internal.hpp"
 
 // comment so clang-format does not move this
@@ -515,6 +516,8 @@ void RecordComponent::flush(
 void RecordComponent::read()
 {
     readBase();
+    internal::ScientificDefaults<RecordComponent>::readDefaults(
+        IOHandler()->m_standard);
 }
 
 namespace

src/backend/BaseRecord.cpp

@@ -765,13 +765,6 @@ inline bool BaseRecord<T_elem>::scalar() const
     return this->datasetDefined();
 }
 
-template <typename T_elem>
-inline void BaseRecord<T_elem>::readBase()
-{
-    internal::ScientificDefaults<BaseRecord<T_elem>>::readDefaults(
-        this->IOHandler()->m_standard);
-}
-
 template <typename T_elem>
 inline void BaseRecord<T_elem>::flush(
     std::string const &name, internal::FlushParams const &flushParams)

src/backend/ScientificDefaults.cpp

@@ -492,7 +492,8 @@ void ScientificDefaults<Child>::defaults_impl(OpenpmdStandard standard)
     else if constexpr (std::is_same_v<Child, Record>)
     {
         defaultAttribute("timeOffset")
-            .template withSetter<Record>(0.f, &Record::setTimeOffset)(wor);
+            .template withSetter<Record>(0.f, &Record::setTimeOffset)
+            .withReader(float_types, require_scalar)(wor);
 
         auto const &keyInParent = asChild().writable().ownKeyWithinParent;
         if (keyInParent == "position" || keyInParent == "positionOffset")