Add feedback: add featuregate and correct url validation

Signed-off-by: sandert-k8s <sandert98@gmail.com>

Author: sandert-k8s

features/features.go

@@ -1011,4 +1011,10 @@ var (
 					enhancementPR("https://github.com/openshift/enhancements/pull/1933").
 					enable(inDevPreviewNoUpgrade(), inTechPreviewNoUpgrade()).
 					mustRegister()
-)
+
+	FeatureGateConsoleCustomLoginServerURL = newFeatureGate("ConsoleCustomLoginServerURL").
+							reportProblemsToJiraComponent("Management Console").
+							contactPerson("console-dev").
+							productScope(ocpSpecific).
+							enable(inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).
+							mustRegister()

operator/v1/types_console.go

@@ -344,9 +344,13 @@ type ConsoleCustomization struct {
 	// or any other front-end that accepts oc login traffic) without changing
 	// how the console itself communicates with the Kubernetes API server.
 	// When omitted, the console falls back to the standard cluster API server URL.
-	// Must be a valid HTTPS URL.
+	// The value must be either empty or an absolute HTTPS URL (i.e. starting with
+	// 'https://') and must not exceed 1024 characters.
+	// +openshift:enable:FeatureGate=ConsoleCustomLoginServerURL
 	// +optional
-	// +kubebuilder:validation:Pattern=`^$|^https://[^\s].*$`
+	// +kubebuilder:validation:XValidation:rule="size(self) == 0 || isURL(self)",message="custom login server url must be a valid absolute URL"
+	// +kubebuilder:validation:XValidation:rule="size(self) == 0 || url(self).getScheme() == 'https'",message="custom login server url scheme must be https"
+	// +kubebuilder:validation:MaxLength=1024
 	CustomLoginServerURL string `json:"customLoginServerURL,omitempty"`
 }
 

operator/v1/zz_generated.crd-manifests/0000_50_console_01_consoles.crd.yaml

@@ -153,6 +153,22 @@ spec:
                       customProductName is the name that will be displayed in page titles, logo alt text, and the about dialog
                       instead of the normal OpenShift product name.
                     type: string
+                  customLoginServerURL:
+                    description: |-
+                      customLoginServerURL is an optional field that, when set, overrides the server
+                      address displayed in the 'oc login' command shown in the console. Use this
+                      to advertise an alternative API endpoint (for example, a Proxy
+                      or any other front-end that accepts oc login traffic) without changing
+                      how the console itself communicates with the Kubernetes API server.
+                      When omitted, the console falls back to the standard cluster API server URL.
+                      Must be a valid HTTPS URL.
+                    maxLength: 1024
+                    type: string
+                    x-kubernetes-validations:
+                    - message: custom login server url must be a valid absolute URL
+                      rule: size(self) == 0 || isURL(self)
+                    - message: custom login server url scheme must be https
+                      rule: size(self) == 0 || url(self).getScheme() == 'https'
                   developerCatalog:
                     description: developerCatalog allows to configure the shown developer
                       catalog categories (filters) and types (sub-catalogs).