[ci_gen_kustomize_values] Co-locate provisionserver with metal3 to prevent DHCP failures

When metal3-dnsmasq pod restarts during a node's DHCP lease renewal on
the provisioning network (172.23.0.0/24), NetworkManager fails to renew
and sets ipv4.method=disabled. NMState operator then preserves this
disabled state, causing permanent loss of provisioning network
connectivity on that node.

The issue occurs when OpenStackProvisionServer and metal3 pods run on
different nodes. If metal3 restarts while a node is attempting DHCP
renewal, the temporary unavailability of metal3-dnsmasq causes the
renewal to fail.

Solution:
Automatically detect the node running metal3 pod (via k8s-app=metal3
label) and configure provisionServerNodeSelector in baremetalSetTemplate
to schedule OpenStackProvisionServer on the same node. This ensures
provisioning network connectivity is maintained because
metal3-static-ip-manager maintains a static IP (172.23.0.3) on the
metal3 node regardless of dnsmasq restarts.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Miguel Angel Nieto Jimenez <mnietoji@redhat.com>

Author: mnietoji

roles/ci_gen_kustomize_values/tasks/main.yml

@@ -14,6 +14,28 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 
+- name: Detect metal3 node for baremetal nodeset provisioning
+  when:
+    - cifmw_ci_gen_kustomize_values_src_file is defined
+    - cifmw_ci_gen_kustomize_values_src_file is match('.*/edpm/nodeset.*')
+  block:
+    - name: Get metal3 pod information
+      kubernetes.core.k8s_info:
+        kubeconfig: "{{ cifmw_openshift_kubeconfig }}"
+        kind: Pod
+        namespace: openshift-machine-api
+        label_selectors:
+          - k8s-app=metal3
+      register: _cifmw_kustomize_deploy_metal3_pod_info
+
+    - name: Set metal3 node for provisionserver nodeSelector
+      ansible.builtin.set_fact:
+        cifmw_kustomize_deploy_metal3_node: "{{ _cifmw_kustomize_deploy_metal3_pod_info.resources[0].spec.nodeName }}"
+        cacheable: true
+      when:
+        - _cifmw_kustomize_deploy_metal3_pod_info.resources is defined
+        - _cifmw_kustomize_deploy_metal3_pod_info.resources | length > 0
+
 - name: Generate snippets files
   ansible.builtin.include_tasks: generate_snippets.yml
 

roles/ci_gen_kustomize_values/templates/nfv-ovs-dpdk-sriov-hci/edpm-nodeset-values/values.yaml.j2

@@ -43,3 +43,9 @@ data:
       - "{{ svc }}"
 {%   endfor                                                                            %}
 {% endif                                                                               %}
+{% if cifmw_kustomize_deploy_metal3_node is defined                                    %}
+  baremetalSetTemplate:
+{{ ((original_content.data | default({})).baremetalSetTemplate | default({})) | to_nice_yaml(indent=2) | indent(4, first=true) }}
+    provisionServerNodeSelector:
+      kubernetes.io/hostname: "{{ cifmw_kustomize_deploy_metal3_node }}"
+{% endif                                                                               %}

roles/ci_gen_kustomize_values/templates/ovs-dpdk-sriov-2nodesets/edpm-nodeset-values/values.yaml.j2

@@ -56,3 +56,9 @@ data:
       - "{{ svc }}"
 {%   endfor                                                                            %}
 {% endif                                                                               %}
+{% if cifmw_kustomize_deploy_metal3_node is defined                                    %}
+  baremetalSetTemplate:
+{{ ((original_content.data | default({})).baremetalSetTemplate | default({})) | to_nice_yaml(indent=2) | indent(4, first=true) }}
+    provisionServerNodeSelector:
+      kubernetes.io/hostname: "{{ cifmw_kustomize_deploy_metal3_node }}"
+{% endif                                                                               %}

roles/ci_gen_kustomize_values/templates/ovs-dpdk-sriov-ipv6-2nodesets/edpm-nodeset-values/values.yaml.j2

@@ -56,3 +56,9 @@ data:
       - "{{ svc }}"
 {%   endfor                                                                            %}
 {% endif                                                                               %}
+{% if cifmw_kustomize_deploy_metal3_node is defined                                    %}
+  baremetalSetTemplate:
+{{ ((original_content.data | default({})).baremetalSetTemplate | default({})) | to_nice_yaml(indent=2) | indent(4, first=true) }}
+    provisionServerNodeSelector:
+      kubernetes.io/hostname: "{{ cifmw_kustomize_deploy_metal3_node }}"
+{% endif                                                                               %}

roles/ci_gen_kustomize_values/templates/ovs-dpdk-sriov-ipv6/edpm-nodeset-values/values.yaml.j2

@@ -43,3 +43,9 @@ data:
       - "{{ svc }}"
 {%   endfor                                                                            %}
 {% endif                                                                               %}
+{% if cifmw_kustomize_deploy_metal3_node is defined                                    %}
+  baremetalSetTemplate:
+{{ ((original_content.data | default({})).baremetalSetTemplate | default({})) | to_nice_yaml(indent=2) | indent(4, first=true) }}
+    provisionServerNodeSelector:
+      kubernetes.io/hostname: "{{ cifmw_kustomize_deploy_metal3_node }}"
+{% endif                                                                               %}

roles/ci_gen_kustomize_values/templates/ovs-dpdk-sriov/edpm-nodeset-values/values.yaml.j2

@@ -43,3 +43,9 @@ data:
       - "{{ svc }}"
 {%   endfor                                                                            %}
 {% endif                                                                               %}
+{% if cifmw_kustomize_deploy_metal3_node is defined                                    %}
+  baremetalSetTemplate:
+{{ ((original_content.data | default({})).baremetalSetTemplate | default({})) | to_nice_yaml(indent=2) | indent(4, first=true) }}
+    provisionServerNodeSelector:
+      kubernetes.io/hostname: "{{ cifmw_kustomize_deploy_metal3_node }}"
+{% endif                                                                               %}

roles/ci_gen_kustomize_values/templates/ovs-dpdk/edpm-nodeset-values/values.yaml.j2

@@ -42,3 +42,9 @@ data:
       - "{{ svc }}"
 {%   endfor                                                                            %}
 {% endif                                                                               %}
+{% if cifmw_kustomize_deploy_metal3_node is defined                                    %}
+  baremetalSetTemplate:
+{{ ((original_content.data | default({})).baremetalSetTemplate | default({})) | to_nice_yaml(indent=2) | indent(4, first=true) }}
+    provisionServerNodeSelector:
+      kubernetes.io/hostname: "{{ cifmw_kustomize_deploy_metal3_node }}"
+{% endif                                                                               %}

roles/ci_gen_kustomize_values/templates/sriov/edpm-nodeset-values/values.yaml.j2

@@ -42,3 +42,9 @@ data:
       - "{{ svc }}"
 {%   endfor                                                                            %}
 {% endif                                                                               %}
+{% if cifmw_kustomize_deploy_metal3_node is defined                                    %}
+  baremetalSetTemplate:
+{{ ((original_content.data | default({})).baremetalSetTemplate | default({})) | to_nice_yaml(indent=2) | indent(4, first=true) }}
+    provisionServerNodeSelector:
+      kubernetes.io/hostname: "{{ cifmw_kustomize_deploy_metal3_node }}"
+{% endif                                                                               %}