refactor: rename members strings for consistent naming

Author: joragua

owncloudApp/src/main/java/com/owncloud/android/extensions/SpaceMenuOptionExt.kt

@@ -31,7 +31,7 @@ fun SpaceMenuOption.toStringResId() =
         SpaceMenuOption.ENABLE -> R.string.enable_space
         SpaceMenuOption.DELETE -> R.string.delete_space
         SpaceMenuOption.SET_ICON -> R.string.set_space_icon
-        SpaceMenuOption.MEMBERS -> R.string.space_members
+        SpaceMenuOption.MEMBERS -> R.string.members_title
     }
 
 fun SpaceMenuOption.toDrawableResId() =

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/AddMemberFragment.kt

@@ -80,7 +80,7 @@ class AddMemberFragment: Fragment() {
                     is UIResult.Loading -> { }
                     is UIResult.Error -> {
                         Timber.e(uiResult.error, "Failed to retrieve available users and groups")
-                        showErrorInSnackbar(R.string.search_members_failed, uiResult.error)
+                        showErrorInSnackbar(R.string.members_search_failed, uiResult.error)
                     }
                 }
             }
@@ -122,7 +122,7 @@ class AddMemberFragment: Fragment() {
 
     override fun onActivityCreated(savedInstanceState: Bundle?) {
         super.onActivityCreated(savedInstanceState)
-        requireActivity().setTitle(R.string.add_member)
+        requireActivity().setTitle(R.string.members_add)
     }
 
     companion object {

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/SearchMembersAdapter.kt

@@ -54,9 +54,9 @@ class SearchMembersAdapter: RecyclerView.Adapter<SearchMembersAdapter.SearchMemb
                 if (isGroup) R.string.content_description_member_group else R.string.content_description_member_user, member.displayName
             )
             memberRole.text = if (isGroup) {
-                holder.itemView.context.getString(R.string.member_group)
+                holder.itemView.context.getString(R.string.member_type_group)
             } else {
-                if (member.surname == USER_SURNAME) holder.itemView.context.getString(R.string.member_user) else member.surname
+                if (member.surname == USER_SURNAME) holder.itemView.context.getString(R.string.member_type_user) else member.surname
             }
         }
     }

owncloudApp/src/main/res/layout/members_fragment.xml

@@ -41,7 +41,7 @@
                 android:layout_height="50dp"
                 android:layout_centerVertical="true"
                 android:gravity="center"
-                android:text="@string/space_members"
+                android:text="@string/members_title"
                 android:layout_marginStart="@dimen/standard_half_margin"
                 android:textAllCaps="true"
                 android:textColor="@color/white"

owncloudApp/src/main/res/values/strings.xml

@@ -877,11 +877,11 @@
     <string name="delete_space_correctly">Space deleted correctly</string>
     <string name="delete_space_failed">Space could not be deleted</string>
     <string name="set_space_icon">Set icon</string>
-    <string name="space_members">Members</string>
-    <string name="add_member">Add member</string>
-    <string name="search_members_failed">No results found</string>
-    <string name="member_user">User</string>
-    <string name="member_group">Group</string>
+    <string name="members_title">Members</string>
+    <string name="members_add">Add member</string>
+    <string name="members_search_failed">No results found</string>
+    <string name="member_type_user">User</string>
+    <string name="member_type_group">Group</string>
 
     <string name="feedback_dialog_get_in_contact_description"><![CDATA[ Ask for help in our <a href=\"%1$s\"><b>forum</b></a> or contribute in our <a href=\"%2$s\"><b>GitHub repo</b></a>]]></string>