Skip to content

Commit d7f9c62

Browse files
committed
feat: improve accessibility for remove member button
1 parent 6863e3f commit d7f9c62

3 files changed

Lines changed: 2 additions & 2 deletions

File tree

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersAdapter.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ class SpaceMembersAdapter(
6969
val memberRole = OCRoleType.parseFromId(member.roles.first())
7070
val numberOfManagers = members.count { it.roles.contains(OCRoleType.toString(OCRoleType.CAN_MANAGE)) }
7171
removeMemberButton.apply {
72+
contentDescription = holder.itemView.context.getString(R.string.content_description_remove_member_button, member.displayName)
7273
isVisible = canRemoveMembers && !(memberRole == OCRoleType.CAN_MANAGE && numberOfManagers == 1)
7374
setOnClickListener {
7475
listener.onRemoveMember(member)

owncloudApp/src/main/res/layout/member_item.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@
112112
android:background="?android:attr/selectableItemBackground"
113113
android:focusable="true"
114114
android:src="@drawable/ic_action_delete_grey"
115-
android:contentDescription="@string/content_description_remove_member_button"
116115
android:visibility="gone"
117116
tools:visibility="visible" />
118117

owncloudApp/src/main/res/values/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -833,7 +833,7 @@
833833
<string name="content_description_add_member">Add new member</string>
834834
<string name="content_description_invite_member_button">Invite member</string>
835835
<string name="content_description_expiration_date_switch">Expiration date</string>
836-
<string name="content_description_remove_member_button">Remove member</string>
836+
<string name="content_description_remove_member_button">Remove member %1$s</string>
837837

838838
<string name="create_shortcut_dialog_title">Create a shortcut</string>
839839
<string name="create_shortcut_dialog_url">URL</string>

0 commit comments

Comments
 (0)