fix: update session state management to handle closing state

Author: ionutmanolache-okta

lib/client.js

@@ -35,6 +35,7 @@ module.exports = function (dependencies) {
 
   function Client(options) {
     this.isDestroyed = false;
+    this.isSessionClosing = false;
     this.config = config(options);
     this.logger = defaultLogger;
     this.errorLogger = defaultErrorLogger;
@@ -91,11 +92,13 @@ module.exports = function (dependencies) {
       return;
     }
     if (!session.closed) {
+      this.isSessionClosing = true;
       await new Promise(resolve => {
         session.close(() => {
           resolve();
         });
       });
+      this.isSessionClosing = false;
     }
     this.destroySession(session);
   };
@@ -192,6 +195,7 @@ module.exports = function (dependencies) {
       // Connect manageChannelsSession.
       if (
         !this.manageChannelsSession ||
+        this.isSessionClosing ||
         this.manageChannelsSession.closed ||
         this.manageChannelsSession.destroyed
       ) {
@@ -243,7 +247,7 @@ module.exports = function (dependencies) {
       }
     } else {
       // Connect to standard session.
-      if (!this.session || this.session.closed || this.session.destroyed) {
+      if (!this.session || this.isSessionClosing ||  this.session.closed || this.session.destroyed) {
         try {
           await this.connect();
         } catch (error) {
@@ -345,11 +349,12 @@ module.exports = function (dependencies) {
         this.config
       ));
 
-      if (this.logger.enabled) {
-        this.session.on('connect', () => {
+      this.session.on('connect', () => {
+        this.isSessionClosing = false;
+        if (this.logger.enabled) {
           this.logger('Session connected');
-        });
-      }
+        }
+      });
 
       this.session.on('close', () => {
         if (this.errorLogger.enabled) {
@@ -424,11 +429,12 @@ module.exports = function (dependencies) {
         config
       ));
 
-      if (this.logger.enabled) {
-        this.manageChannelsSession.on('connect', () => {
+      this.manageChannelsSession.on('connect', () => {
+        this.isSessionClosing = false;
+        if (this.logger.enabled) {
           this.logger('ManageChannelsSession connected');
-        });
-      }
+        }
+      });
 
       this.manageChannelsSession.on('close', () => {
         if (this.errorLogger.enabled) {