Rename option to error_ignore_args

Per feedback from Tim on the RFC. Also rationalize the default vs.
recommended INI settings.

This does invert the semantics for the option; the if is changed
accordingly.

Author: NattyNarwhal

Zend/tests/display_error_function_args.phpt

@@ -1,7 +1,7 @@
 --TEST--
 Displaying function arguments in errors
 --INI--
-display_error_function_args=On
+error_ignore_args=Off
 --FILE--
 <?php
 
@@ -12,7 +12,7 @@ unlink('/');
 // XXX: May be better to provide a new zend_test func?
 password_hash("test", PASSWORD_BCRYPT, array("salt" => "123456789012345678901" . chr(0)));
 
-ini_set("display_error_function_args", "Off");
+ini_set("error_ignore_args", "On");
 
 unlink('/');
 password_hash("test", PASSWORD_BCRYPT, array("salt" => "123456789012345678901" . chr(0)));

main/main.c

@@ -803,8 +803,8 @@ PHP_INI_BEGIN()
 
 	STD_PHP_INI_ENTRY_EX("display_errors",		"1",		PHP_INI_ALL,		OnUpdateDisplayErrors,	display_errors,			php_core_globals,	core_globals, display_errors_mode)
 	STD_PHP_INI_BOOLEAN("display_startup_errors",	"1",	PHP_INI_ALL,		OnUpdateBool,			display_startup_errors,	php_core_globals,	core_globals)
-	STD_PHP_INI_BOOLEAN("display_error_function_args",	"0",	PHP_INI_ALL,		OnUpdateBool,			display_error_function_args,	php_core_globals,	core_globals)
 	STD_PHP_INI_BOOLEAN("enable_dl",			"1",		PHP_INI_SYSTEM,		OnUpdateBool,			enable_dl,				php_core_globals,	core_globals)
+	STD_PHP_INI_BOOLEAN("error_ignore_args",	"0",	PHP_INI_ALL,		OnUpdateBool,			error_ignore_args,	php_core_globals,	core_globals)
 	STD_PHP_INI_BOOLEAN("expose_php",			"1",		PHP_INI_SYSTEM,		OnUpdateBool,			expose_php,				php_core_globals,	core_globals)
 	STD_PHP_INI_ENTRY("docref_root", 			"", 		PHP_INI_ALL,		OnUpdateString,			docref_root,			php_core_globals,	core_globals)
 	STD_PHP_INI_ENTRY("docref_ext",				"",			PHP_INI_ALL,		OnUpdateString,			docref_ext,				php_core_globals,	core_globals)
@@ -1141,7 +1141,7 @@ PHPAPI ZEND_COLD void php_verror(const char *docref, const char *params, int typ
 		 * By default, this is disabled because it requires rewriting
 		 * almost all PHPT files.
 		 */
-		if (PG(display_error_function_args)) {
+		if (PG(error_ignore_args) == false) {
 			dynamic_params = zend_trace_current_function_args_string();
 		}
 		origin_len = spprintf(&origin, 0, "%s%s%s(%s)", class_name, space, function, dynamic_params ? ZSTR_VAL(dynamic_params) : params);

main/php_globals.h

@@ -61,7 +61,7 @@ struct _php_core_globals {
 
 	uint8_t display_errors;
 	bool display_startup_errors;
-	bool display_error_function_args;
+	bool error_ignore_args;
 	bool log_errors;
 	bool ignore_repeated_errors;
 	bool ignore_repeated_source;

php.ini-development

@@ -612,13 +612,13 @@ ignore_repeated_source = Off
 ;fatal_error_backtraces = On
 
 ; This directive controls whether PHP will print the actual arguments of a
-; function upon an error. If disabled (or there was an error fetching the
+; function upon an error. If this is on (or there was an error fetching the
 ; arguments), the function providing the error may optionally provide some
 ; additional information after the problem function's name.
 ; Default Value: Off
-; Development Value: On
-; Production Value: On
-display_error_function_args = On
+; Development Value: Off
+; Production Value: Off
+;error_ignore_args = Off
 
 ;;;;;;;;;;;;;;;;;
 ; Data Handling ;

php.ini-production

@@ -614,13 +614,13 @@ ignore_repeated_source = Off
 ;fatal_error_backtraces = On
 
 ; This directive controls whether PHP will print the actual arguments of a
-; function upon an error. If disabled (or there was an error fetching the
+; function upon an error. If this is on (or there was an error fetching the
 ; arguments), the function providing the error may optionally provide some
 ; additional information after the problem function's name.
 ; Default Value: Off
-; Development Value: On
-; Production Value: On
-display_error_function_args = On
+; Development Value: Off
+; Production Value: Off
+;error_ignore_args = Off
 
 ;;;;;;;;;;;;;;;;;
 ; Data Handling ;

run-tests.php

@@ -275,7 +275,7 @@ function main(): void
         'fatal_error_backtraces=Off',
         'display_errors=1',
         'display_startup_errors=1',
-        'display_error_function_args=0',
+        'error_ignore_args=1',
         'log_errors=0',
         'html_errors=0',
         'track_errors=0',