diff --git a/Zend/Optimizer/compact_vars.c b/Zend/Optimizer/compact_vars.c index 9898714a17c5e..0bcad585eec6c 100644 --- a/Zend/Optimizer/compact_vars.c +++ b/Zend/Optimizer/compact_vars.c @@ -23,7 +23,7 @@ /* This pass removes all CVs and temporaries that are completely unused. It does *not* merge any CVs or TMPs. * This pass does not operate on SSA form anymore. */ void zend_optimizer_compact_vars(zend_op_array *op_array) { - int i; + uint32_t i; ALLOCA_FLAG(use_heap1); ALLOCA_FLAG(use_heap2); diff --git a/Zend/Optimizer/optimize_temp_vars_5.c b/Zend/Optimizer/optimize_temp_vars_5.c index de0b189d5dca1..07b1ea38a2fa0 100644 --- a/Zend/Optimizer/optimize_temp_vars_5.c +++ b/Zend/Optimizer/optimize_temp_vars_5.c @@ -43,7 +43,7 @@ void zend_optimize_temporary_variables(zend_op_array *op_array, zend_optimizer_ctx *ctx) { uint32_t T = op_array->T; - int offset = op_array->last_var; + uint32_t offset = op_array->last_var; uint32_t bitset_len; zend_bitset taken_T; /* T index in use */ zend_op **start_of_T; /* opline where T is first used */ diff --git a/Zend/Optimizer/sccp.c b/Zend/Optimizer/sccp.c index 60afe3165f775..0c3a922d04e58 100644 --- a/Zend/Optimizer/sccp.c +++ b/Zend/Optimizer/sccp.c @@ -2381,7 +2381,7 @@ static uint32_t replace_constant_operands(sccp_ctx *ctx) { /* We iterate the variables backwards, so we can eliminate sequences like INIT_ROPE * and INIT_ARRAY. */ - for (i = ssa->vars_count - 1; i >= op_array->last_var; i--) { + for (i = ssa->vars_count - 1; i >= (int)op_array->last_var; i--) { zend_ssa_var *var = &ssa->vars[i]; zval *value; int use; diff --git a/Zend/Optimizer/zend_inference.c b/Zend/Optimizer/zend_inference.c index 6963fc63dd15c..09f2f4cd24b16 100644 --- a/Zend/Optimizer/zend_inference.c +++ b/Zend/Optimizer/zend_inference.c @@ -4885,7 +4885,7 @@ static void zend_mark_cv_references(const zend_op_array *op_array, const zend_sc ZEND_API zend_result zend_ssa_inference(zend_arena **arena, const zend_op_array *op_array, const zend_script *script, zend_ssa *ssa, zend_long optimization_level) /* {{{ */ { zend_ssa_var_info *ssa_var_info; - int i; + uint32_t i; if (!ssa->var_info) { ssa->var_info = zend_arena_calloc(arena, ssa->vars_count, sizeof(zend_ssa_var_info)); diff --git a/Zend/Optimizer/zend_ssa.c b/Zend/Optimizer/zend_ssa.c index 99978da9d7e80..020a812799699 100644 --- a/Zend/Optimizer/zend_ssa.c +++ b/Zend/Optimizer/zend_ssa.c @@ -1001,7 +1001,8 @@ ZEND_API zend_result zend_build_ssa(zend_arena **arena, const zend_script *scrip uint32_t set_size; zend_bitset def, in, phi; int *var = NULL; - int i, j, k, changed; + int i, k, changed; + uint32_t j; zend_dfg dfg; ALLOCA_FLAG(dfg_use_heap) ALLOCA_FLAG(var_use_heap) diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c index ee83ee75ff6ea..6a6f5253c3f2a 100644 --- a/Zend/zend_compile.c +++ b/Zend/zend_compile.c @@ -539,7 +539,7 @@ static zend_always_inline uint32_t get_temporary_variable(void) /* {{{ */ static uint32_t lookup_cv(zend_string *name) /* {{{ */{ zend_op_array *op_array = CG(active_op_array); - int i = 0; + uint32_t i = 0; zend_ulong hash_value = zend_string_hash_val(name); while (i < op_array->last_var) { @@ -8486,9 +8486,8 @@ static void zend_compile_closure_uses(zend_ast *ast) /* {{{ */ ZVAL_NULL(&zv); { - int i; - for (i = 0; i < op_array->last_var; i++) { - if (zend_string_equals(op_array->vars[i], var_name)) { + for (uint32_t j = 0; j < op_array->last_var; j++) { + if (zend_string_equals(op_array->vars[j], var_name)) { zend_error_noreturn_unchecked(E_COMPILE_ERROR, "Cannot use lexical variable $%S as a parameter name", var_name); } diff --git a/Zend/zend_compile.h b/Zend/zend_compile.h index 5414467f3f874..5a93ac07076ef 100644 --- a/Zend/zend_compile.h +++ b/Zend/zend_compile.h @@ -548,7 +548,7 @@ struct _zend_op_array { /* END of common elements */ uint32_t cache_size; /* number of run_time_cache_slots * sizeof(void*) */ - int last_var; /* number of CV variables */ + uint32_t last_var; /* number of CV variables */ uint32_t last; /* number of opcodes */ zend_op *opcodes; diff --git a/Zend/zend_execute.c b/Zend/zend_execute.c index 37278c5cb9a23..b28b9ad2b8ac5 100644 --- a/Zend/zend_execute.c +++ b/Zend/zend_execute.c @@ -4278,7 +4278,7 @@ ZEND_API void zend_clean_and_cache_symbol_table(zend_array *symbol_table) /* {{{ static zend_always_inline void i_free_compiled_variables(zend_execute_data *execute_data) /* {{{ */ { zval *cv = EX_VAR_NUM(0); - int count = EX(func)->op_array.last_var; + uint32_t count = EX(func)->op_array.last_var; while (EXPECTED(count != 0)) { i_zval_ptr_dtor(cv); cv++; diff --git a/ext/opcache/jit/zend_jit.c b/ext/opcache/jit/zend_jit.c index 81bbaec04cdea..5b4d0ade918b8 100644 --- a/ext/opcache/jit/zend_jit.c +++ b/ext/opcache/jit/zend_jit.c @@ -2915,9 +2915,7 @@ static int zend_jit(const zend_op_array *op_array, zend_ssa *ssa, const zend_op left_frame = true; } if (!left_frame) { - int j; - - for (j = 0 ; j < op_array->last_var; j++) { + for (uint32_t j = 0 ; j < op_array->last_var; j++) { uint32_t info = zend_ssa_cv_info(op_array, ssa, j); if (info & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF)) { diff --git a/ext/opcache/jit/zend_jit_trace.c b/ext/opcache/jit/zend_jit_trace.c index 3a676125b800e..c1cb338719257 100644 --- a/ext/opcache/jit/zend_jit_trace.c +++ b/ext/opcache/jit/zend_jit_trace.c @@ -661,7 +661,7 @@ static int zend_jit_trace_add_phis(zend_jit_trace_rec *trace_buffer, uint32_t ss { const zend_op_array *op_array; zend_jit_trace_rec *p; - int k, vars_count; + uint32_t vars_count; zend_bitset use, def; uint32_t build_flags = ZEND_SSA_RC_INFERENCE | ZEND_SSA_USE_CV_RESULTS; uint32_t set_size; @@ -712,7 +712,7 @@ static int zend_jit_trace_add_phis(zend_jit_trace_rec *trace_buffer, uint32_t ss } else { vars_count = op_array->last_var + op_array->T; } - for (k = 0; k < vars_count; k++) { + for (uint32_t k = 0; k < vars_count; k++) { if (zend_bitset_in(use, k)) { zend_ssa_phi *phi = zend_arena_calloc(&CG(arena), 1, ZEND_MM_ALIGNED_SIZE(sizeof(zend_ssa_phi)) + @@ -7814,7 +7814,8 @@ static void zend_jit_dump_trace(zend_jit_trace_rec *trace_buffer, zend_ssa *tssa const zend_op_array *op_array; const zend_op *opline; uint32_t level = 1 + trace_buffer[0].level; - int idx, len, i, v, vars_count, call_level; + int len, v; + uint32_t idx, i, vars_count, call_level; ZEND_ASSERT(p->op == ZEND_JIT_TRACE_START); op_array = p->op_array; diff --git a/ext/opcache/zend_persist.c b/ext/opcache/zend_persist.c index 9bc2496837ce4..ad38f11ba590c 100644 --- a/ext/opcache/zend_persist.c +++ b/ext/opcache/zend_persist.c @@ -681,9 +681,8 @@ static void zend_persist_op_array_ex(zend_op_array *op_array, zend_persistent_sc } if (op_array->vars) { - int i; op_array->vars = zend_shared_memdup_put_free(op_array->vars, sizeof(zend_string*) * op_array->last_var); - for (i = 0; i < op_array->last_var; i++) { + for (uint32_t i = 0; i < op_array->last_var; i++) { zend_accel_store_interned_string(op_array->vars[i]); } } diff --git a/ext/opcache/zend_persist_calc.c b/ext/opcache/zend_persist_calc.c index 0b0ff51d0d4df..8fb1d9ddc3ba9 100644 --- a/ext/opcache/zend_persist_calc.c +++ b/ext/opcache/zend_persist_calc.c @@ -326,10 +326,8 @@ static void zend_persist_op_array_calc_ex(zend_op_array *op_array) } if (op_array->vars) { - int i; - ADD_SIZE(sizeof(zend_string*) * op_array->last_var); - for (i = 0; i < op_array->last_var; i++) { + for (uint32_t i = 0; i < op_array->last_var; i++) { ADD_INTERNED_STRING(op_array->vars[i]); } }