Improve PHP and phpBB compatibility checks

Author: iMattPro

includes/settings.php

@@ -166,6 +166,26 @@ public function validate()
 			$validation_errors[] = ['BOARDS_DIR_MISSING', $this->get_boards_dir()];
 		}
 
+		// Validate alt environment boards
+		if ($this->settings['alt_env'])
+		{
+			$phpbb_version = get_phpbb_version($this->qi_path . 'sources/phpBB3_alt/' . $this->settings['alt_env']);
+			// phpBB 3.1.x is not compat with PHP >= 7 (700000)
+			// phpBB 3.2.0-3.2.1 is not compat with PHP >= 7.2 (702000)
+			// phpBB 3.2.x is not compat with PHP >= 7.3 (703000)
+			// phpBB 3.3.x is not compat with PHP < 7.1.3 (70103)
+			// phpBB 4.0.x is not compat with PHP < 7.3 (703000)
+			if ((PHP_VERSION_ID >= 70000 && qi::phpbb_version_compare($phpbb_version, '3.2', '<')) ||
+				(PHP_VERSION_ID >= 70200 && qi::phpbb_version_compare($phpbb_version, '3.2.2', '<')) ||
+				(PHP_VERSION_ID >= 70300 && qi::phpbb_version_compare($phpbb_version, '3.3', '<')) ||
+				(PHP_VERSION_ID < 70103 && qi::phpbb_version_compare($phpbb_version, '3.3', '>=')) ||
+				(PHP_VERSION_ID < 70300 && qi::phpbb_version_compare($phpbb_version, '4.0', '>='))
+			)
+			{
+				$validation_errors[] = ['PHP_INCOMPATIBLE', $phpbb_version, PHP_VERSION];
+			}
+		}
+
 		// Adjust boards URL path
 		qi_file::append_slash($this->settings['boards_url']);
 

language/en/qi.php

@@ -230,7 +230,7 @@
 	'PHPBB_QI_FULLLINK'	=> '<a href="https://www.phpbb.com/customise/db/official_tool/phpbb3_quickinstall/">phpBB<small><sup>&reg;</sup></small> QuickInstall</a> %s for phpBB 3.0 - 4.0',
 	'PHPBB_QI_TITLE'	=> 'phpBB&reg; QuickInstall',
 
-	'PHP7_INCOMPATIBLE'	=> 'The board you are trying to install, phpBB %1$s, is not compatible with PHP %2$s.',
+	'PHP_INCOMPATIBLE'	=> 'The board you are trying to use, phpBB %1$s, is not compatible with PHP %2$s. Refer to the Documentation for our compatibility grid.',
 	'PHPINFO'			=> 'PHP info',
 	'PHPINFO_TITLE'		=> 'PHP information',
 	'PHPINFO_EXPLAIN'	=> 'This page lists information on the version of PHP installed on this server. It includes details of loaded modules, available variables and default settings. This information may be useful when diagnosing problems.<br /><br />Please be aware that some hosting companies will limit what information is displayed here for security reasons.<br /><br />You are advised to only give out details on this page on a need to know basis.',

modules/qi_create.php

@@ -25,12 +25,16 @@ public function run()
 		// phpBB 3.1.x is not compat with PHP 7 (700000)
 		// phpBB 3.2.0-3.2.1 is not compat with PHP 7.2 (702000)
 		// phpBB 3.2.x is not compat with PHP 7.3 (703000)
+		// phpBB 3.3.x is not compat with PHP < 7.1.3 (70103)
+		// phpBB 4.0.x is not compat with PHP < 7.3 (703000)
 		if ((PHP_VERSION_ID >= 70000 && !defined('PHPBB_32')) ||
 			(PHP_VERSION_ID >= 70200 && qi::phpbb_version_compare(PHPBB_VERSION, '3.2.2', '<')) ||
-			(PHP_VERSION_ID >= 70300 && !defined('PHPBB_33'))
+			(PHP_VERSION_ID >= 70300 && !defined('PHPBB_33')) ||
+			(PHP_VERSION_ID < 70103 && defined('PHPBB_33')) ||
+			(PHP_VERSION_ID < 70300 && defined('PHPBB_40'))
 		)
 		{
-			trigger_error(qi::lang('PHP7_INCOMPATIBLE', PHPBB_VERSION, PHP_VERSION));
+			trigger_error(qi::lang('PHP_INCOMPATIBLE', PHPBB_VERSION, PHP_VERSION));
 		}
 
 		if (defined('PHPBB_31'))