Playwright locator API intention

[braydend]

Hi there,

I'm looking at using this project, but I've found that the getByText implementation differs from the standard Playwright implementation in regards to how text matching occurs.

If I'm not mistaken, the implementation of getByText in this project is attempting to make an exact string match. The standard Playwright API allows for passing in regular expressions in order to facilitate partial text matches. Is this a deliberate decision to only allow for exact string matches?

Thanks so much for your work on this project!

[smnandre]

Hi @braydend

To be honest i've spent so many nights (you cannot imagine) on this project, rewrote it couple a few 👼 of times from scratch, memories kinda blur right now... In the end, my only rule was to match 1-1 the JS api of MS Playwright (that's when I introduced the interfaces)

I've then had hard time with work.. losing most personal time or energy ... so there is a period of time where I'm not 100% confident of "why" I did things, and did rest my work on the guardrails (tests/sa/etc) I created before..

JS docs states for FrameLocator:

---

Arguments
text string | RegExp#

Text to locate the element for.

Matching by text always normalizes whitespace, even with exact match. For example, it turns multiple spaces into one, turns line breaks into spaces and ignores leading and trailing whitespace.

---

would you like to help on this ? contributing is easy here and I can help you if you want !

[braydend]

I'd be happy to try and contribute!

I just wanted to check your intentions behind the API before I contributed anything that was misaligned.

[smnandre]

They are simple: offering what Playwright can bring to the PHP ecosystem what it deserves: a modern, real, browser automation/testing solution.

I have no others than that. And I would be very happy if anyone jumped on board of this project to contribute and help move things towards :)

[braydend]

Closing at #76 was merged