Skip to content

Commit d250772

Browse files
authored
Fix pane base position
1 parent 3f51d3a commit d250772

1 file changed

Lines changed: 27 additions & 11 deletions

File tree

packages/react/src/PageLayout/PageLayout.module.css

Lines changed: 27 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -440,18 +440,21 @@ body[data-page-layout-dragging='true'] * {
440440
}
441441
}
442442

443-
&:where([data-position='end']) {
444-
/* stylelint-disable-next-line primer/spacing */
445-
margin-top: var(--spacing-row);
446-
flex-direction: column;
447-
order: var(--region-order-pane-end);
448-
}
443+
/* Base position (non-responsive) - applies at narrow viewports only */
444+
@media (--viewportRange-narrow) {
445+
&:where([data-position='end']) {
446+
/* stylelint-disable-next-line primer/spacing */
447+
margin-top: var(--spacing-row);
448+
flex-direction: column;
449+
order: var(--region-order-pane-end);
450+
}
449451

450-
&:where([data-position='start']) {
451-
/* stylelint-disable-next-line primer/spacing */
452-
margin-bottom: var(--spacing-row);
453-
flex-direction: column-reverse;
454-
order: var(--region-order-pane-start);
452+
&:where([data-position='start']) {
453+
/* stylelint-disable-next-line primer/spacing */
454+
margin-bottom: var(--spacing-row);
455+
flex-direction: column-reverse;
456+
order: var(--region-order-pane-start);
457+
}
455458
}
456459

457460
@media screen and (min-width: 768px) {
@@ -470,6 +473,19 @@ body[data-page-layout-dragging='true'] * {
470473
max-height: 100vh;
471474
}
472475

476+
/* Base position (non-responsive) - applies at regular+ viewports */
477+
&:where([data-position='end']) {
478+
/* stylelint-disable-next-line primer/spacing */
479+
margin-left: var(--spacing-column);
480+
flex-direction: row-reverse;
481+
}
482+
483+
&:where([data-position='start']) {
484+
/* stylelint-disable-next-line primer/spacing */
485+
margin-right: var(--spacing-column);
486+
flex-direction: row;
487+
}
488+
473489
&:where([data-position-regular='end']) {
474490
/* stylelint-disable-next-line primer/spacing */
475491
margin-left: var(--spacing-column);

0 commit comments

Comments
 (0)