Fix #1715: BUG: reloaders error while setting "reloader: true" in clus (#1716)

* Fix #1715: skip reloader entries with empty namespace

* Fix #1715: BUG: reloaders error while setting "reloader: true" in clust

* Fix BUG: reloaders error while setting "reloader: true" in clust

Author: utafrali

lib/clusterops/reloader.go

@@ -112,7 +112,7 @@ func deployReloaderInstance(ctx context.Context, reloaderClient client.Client,
 	reloaderInfo := make([]libsveltosv1beta1.ReloaderInfo, 0, len(resources))
 	for i := range resources {
 		resource := &resources[i]
-		if watchForRollingUpgrade(resource) {
+		if watchForRollingUpgrade(resource) && resource.Namespace != "" {
 			reloaderInfo = append(reloaderInfo,
 				libsveltosv1beta1.ReloaderInfo{
 					Namespace: resource.Namespace,

lib/clusterops/reloader_utils_test.go

@@ -99,6 +99,27 @@ var _ = Describe("Reloader utils", func() {
 		Expect(reflect.DeepEqual(reloaders.Items[0].Spec.ReloaderInfo, reloaderInfo)).To(BeTrue())
 	})
 
+	It("deployReloaderInstance skips resources with empty namespace", func() {
+		c := fake.NewClientBuilder().WithScheme(scheme).Build()
+
+		resources := []corev1.ObjectReference{
+			{Kind: "Deployment", Namespace: randomString(), Name: randomString()},
+			{Kind: "Deployment", Namespace: "", Name: randomString()},
+			{Kind: "DaemonSet", Namespace: "", Name: randomString()},
+		}
+
+		clusterProfileName := randomString()
+		feature := libsveltosv1beta1.FeatureHelm
+		Expect(clusterops.DeployReloaderInstance(context.TODO(), c, clusterProfileName,
+			feature, resources, textlogger.NewLogger(textlogger.NewConfig()))).To(Succeed())
+
+		reloaders := &libsveltosv1beta1.ReloaderList{}
+		Expect(c.List(context.TODO(), reloaders)).To(Succeed())
+		Expect(len(reloaders.Items)).To(Equal(1))
+		Expect(len(reloaders.Items[0].Spec.ReloaderInfo)).To(Equal(1))
+		Expect(reloaders.Items[0].Spec.ReloaderInfo[0].Namespace).ToNot(BeEmpty())
+	})
+
 	It("deployReloaderInstance creates/updates reloader instance", func() {
 		c := fake.NewClientBuilder().WithScheme(scheme).Build()