refactor: remove stale resolve_source references and deduplicate wheel URL logic

Removes all remaining references to the deprecated resolve_source hook:
- sources.py: remove dead code checking for resolve_source override
- list_overrides.py: remove from hook scanning list
- docs: update references that mentioned resolve_source

Also eliminates URL construction duplication in bootstrap_requirement_resolver
by using wheels.get_wheel_server_urls() instead of duplicating the logic.

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Signed-off-by: Rohan Devasthale <[email protected]>

Author: rd4398

docs/customization.md

@@ -90,7 +90,7 @@ source url can be provided directly in settings.yaml. Optionally the
 downloaded sdist can be renamed. Both the url and the destination filename
 support templating. The only supported template variable are:
 
-- `version` - it is replaced by the version returned by the `resolve_source`
+- `version` - it is replaced by the resolved version of the package
 - `canonicalized_name` - it is replaced by the canonicalized name of the
   package specified in the requirement, specifically it applies `canonicalize_name(req.nam)`
 

docs/reference/hooks.rst

@@ -197,8 +197,7 @@ Source hooks
     source from a URL.
 
     The arguments are the ``WorkContext``, the ``Requirement`` being
-    evaluated, version of the package being downloaded, the URL
-    from which the source can be downloaded as returned by ``resolve_source``,
+    evaluated, version of the package being downloaded, the download URL,
     and the output directory in which the source should be downloaded.
 
     The return value should be a ``pathlib.Path`` file path to the downloaded source.

src/fromager/bootstrap_requirement_resolver.py

@@ -14,7 +14,7 @@
 from packaging.requirements import Requirement
 from packaging.version import Version
 
-from . import overrides, resolver
+from . import overrides, resolver, wheels
 from .dependency_graph import DependencyGraph
 from .requirements_file import RequirementType
 
@@ -153,14 +153,10 @@ def _resolve(
 
         if pre_built:
             # Resolve prebuilt wheel
-            # Get wheel server URLs
-            wheel_server_urls: list[str] = []
-            if pbi.wheel_server_url:
-                wheel_server_urls.append(pbi.wheel_server_url)
-            else:
-                if self.ctx.wheel_server_url:
-                    wheel_server_urls.append(self.ctx.wheel_server_url)
-                wheel_server_urls.append(resolver.PYPI_SERVER_URL)
+            # Get wheel server URLs (use PyPI as cache/fallback server)
+            wheel_server_urls = wheels.get_wheel_server_urls(
+                self.ctx, req, cache_wheel_server_url=resolver.PYPI_SERVER_URL
+            )
 
             # Try each wheel server until one succeeds
             for url in wheel_server_urls:

src/fromager/commands/list_overrides.py

@@ -77,7 +77,6 @@ def list_overrides(
                 "prebuilt_wheel",
                 # from overrides.py, found by searching for find_override_method
                 "download_source",
-                "resolve_source",
                 "get_resolver_provider",
                 "prepare_source",
                 "build_sdist",

src/fromager/sources.py

@@ -49,7 +49,6 @@ def get_source_type(ctx: context.WorkContext, req: Requirement) -> SourceType:
     pbi = ctx.package_build_info(req)
     if (
         overrides.find_override_method(req.name, "download_source")
-        or overrides.find_override_method(req.name, "resolve_source")
         or overrides.find_override_method(req.name, "get_resolver_provider")
         or pbi.download_source_url(resolve_template=False)
     ):