optimize it as well

Author: kumaraditya303

Include/internal/pycore_optimizer_types.h

@@ -147,6 +147,7 @@ typedef struct _Py_UOpsAbstractFrame {
     int stack_len;
     int locals_len;
     bool caller; // We have made a call from this frame during the trace
+    bool is_recursion_checked;
     JitOptRef callable;
     PyFunctionObject *func;
     PyCodeObject *code;

Lib/test/test_capi/test_opt.py

@@ -2813,6 +2813,23 @@ def testfunc(n):
         self.assertNotIn("_CALL_METHOD_DESCRIPTOR_FAST_WITH_KEYWORDS", uops)
         self.assertNotIn("_GUARD_CALLABLE_METHOD_DESCRIPTOR_FAST_WITH_KEYWORDS", uops)
 
+    def test_check_recursion_limit_deduplicated(self):
+        def testfunc(n):
+            x = 0
+            for _ in range(n):
+                y = "hello"
+                a = y.upper()
+                b = y.lower()
+                x += len(a)
+                x += len(b)
+            return x
+        res, ex = self._run_with_optimizer(testfunc, TIER2_THRESHOLD)
+        self.assertEqual(res, TIER2_THRESHOLD * 10)
+        self.assertIsNotNone(ex)
+        uops = get_opnames(ex)
+        self.assertIn("_CALL_METHOD_DESCRIPTOR_NOARGS_INLINE", uops)
+        self.assertEqual(count_ops(ex, "_CHECK_RECURSION_LIMIT"), 1)
+
     def test_call_intrinsic_1(self):
         def testfunc(n):
             x = 0

Python/optimizer_bytecodes.c

@@ -1394,6 +1394,13 @@ dummy_func(void) {
         }
     }
 
+    op(_CHECK_RECURSION_LIMIT, ( -- )) {
+        if (ctx->frame->is_recursion_checked) {
+            ADD_OP(_NOP, 0, 0);
+        }
+        ctx->frame->is_recursion_checked = true;
+    }
+
     op(_CALL_METHOD_DESCRIPTOR_NOARGS, (callable, self_or_null, args[oparg] -- res)) {
         PyObject *callable_o = sym_get_const(ctx, callable);
         if (callable_o && Py_IS_TYPE(callable_o, &PyMethodDescr_Type)

Python/optimizer_cases.c.h

@@ -1514,6 +1514,7 @@ _Py_uop_frame_new(
     frame->globals_watched = false;
     frame->func = NULL;
     frame->caller = false;
+    frame->is_recursion_checked = false;
     if (ctx->locals.used > ctx->locals.end || ctx->stack.used > ctx->stack.end) {
         ctx->done = true;
         ctx->out_of_space = true;