Skip to content

Commit 80f74a0

Browse files
committed
1.5.3
1.5.3 - 2017-06-06 ------------------------------------------------ ## Webpack * Replaces `cheap-module-source-map` with `source-map` in development, for compatibility with CSS * Adds `sourceMap` option to `common.css.getExtractCSSLoaders()`
1 parent bc7b565 commit 80f74a0

4 files changed

Lines changed: 20 additions & 5 deletions

File tree

CHANGELOG

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
1.5.3 - 2017-06-06
2+
------------------------------------------------
3+
4+
## Webpack
5+
* Replaces `cheap-module-source-map` with `source-map` in development, for compatibility with CSS
6+
* Adds `sourceMap` option to `common.css.getExtractCSSLoaders()`
7+
18
1.5.2 - 2017-06-05
29
------------------------------------------------
310

kit/webpack/common.js

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ export const css = {
8181
}());
8282
},
8383

84-
getExtractCSSLoaders(extractCSS) {
84+
getExtractCSSLoaders(extractCSS, sourceMap = false) {
8585
return (function* loadCss() {
8686
for (const loader of css.loaders) {
8787
// Iterate over CSS/SASS/LESS and yield local and global mod configs
@@ -92,9 +92,17 @@ export const css = {
9292
use: [
9393
{
9494
loader: 'css-loader',
95-
query: Object.assign({}, css.loaderDefaults, mod[1]),
95+
query: Object.assign({}, css.loaderDefaults, {
96+
sourceMap,
97+
}, mod[1]),
9698
},
97-
'postcss-loader',
99+
// Temp fix for `postcss-loader` bug https://github.com/postcss/postcss-loader/issues/250
100+
sourceMap ? {
101+
loader: 'postcss-loader',
102+
options: {
103+
sourceMap: true,
104+
},
105+
} : 'postcss-loader',
98106
...loader.use,
99107
],
100108
fallback: 'style-loader',

kit/webpack/dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import WebpackConfig from 'webpack-config';
1313

1414
export default new WebpackConfig().merge({
1515
// Add source maps
16-
devtool: 'cheap-module-source-map',
16+
devtool: 'source-map',
1717

1818
plugins: [
1919
// Set NODE_ENV to 'development', in case we need verbose debug logs

kit/webpack/server_dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export default [
8888
module: {
8989
loaders: [
9090
// CSS loaders
91-
...css.getExtractCSSLoaders(extractCSS),
91+
...css.getExtractCSSLoaders(extractCSS, true /* sourceMaps = true */),
9292
],
9393
},
9494
plugins: [

0 commit comments

Comments
 (0)