[Php81] Handle different named argument on NullToStrictIntPregSlitFuncCallLimitArgRector

Author: samsonasik

rules-tests/Php81/Rector/FuncCall/NullToStrictIntPregSlitFuncCallLimitArgRector/Fixture/different_named_arg.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictIntPregSlitFuncCallLimitArgRector\Fixture;
+
+class DifferentNamedArg
+{
+    public function run($output)
+    {
+        preg_split('/\s/', $output, NULL, flags: PREG_SPLIT_NO_EMPTY);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php81\Rector\FuncCall\NullToStrictIntPregSlitFuncCallLimitArgRector\Fixture;
+
+class DifferentNamedArg
+{
+    public function run($output)
+    {
+        preg_split('/\s/', $output, 0, flags: PREG_SPLIT_NO_EMPTY);
+    }
+}
+
+?>

rules/Php81/Rector/FuncCall/NullToStrictIntPregSlitFuncCallLimitArgRector.php

@@ -88,9 +88,7 @@ public function refactor(Node $node): ?Node
         }
 
         $args = $node->getArgs();
-        $position = $this->argsAnalyzer->hasNamedArg($args)
-            ? $this->resolveNamedPosition($args)
-            : 2;
+        $position = $this->argsAnalyzer->resolveArgPosition($args, 'limit', 2);
 
         if ($position === null) {
             return null;

src/NodeAnalyzer/ArgsAnalyzer.php

@@ -6,9 +6,15 @@
 
 use PhpParser\Node\Arg;
 use PhpParser\Node\Identifier;
+use Rector\NodeNameResolver\NodeNameResolver;
 
 final class ArgsAnalyzer
 {
+    public function __construct(
+        private readonly NodeNameResolver $nodeNameResolver
+    ) {
+    }
+
     /**
      * @param Arg[] $args
      */
@@ -22,4 +28,24 @@ public function hasNamedArg(array $args): bool
 
         return false;
     }
+
+    /**
+     * @param Arg[] $args
+     */
+    public function resolveArgPosition(array $args, string $name, int $defaultPosition): int
+    {
+        foreach ($args as $position => $arg) {
+            if (! $arg->name instanceof Identifier) {
+                continue;
+            }
+
+            if (! $this->nodeNameResolver->isName($arg->name, $name)) {
+                continue;
+            }
+
+            return $position;
+        }
+
+        return $defaultPosition;
+    }
 }