[php 8.3] Add json_validate rule

Author: Arshid

rules-tests/Php83/Rector/BooleanAnd/JsonValidateRector/Fixture/json_validate_base.php.inc

@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;
 
-if (json_decode($json) !== null && json_last_error() === JSON_ERROR_NONE){
+if (json_decode($json, true, 512) !== null && json_last_error() === JSON_ERROR_NONE){
     echo 1;
 }
 ?>
@@ -11,7 +11,7 @@ if (json_decode($json) !== null && json_last_error() === JSON_ERROR_NONE){
 
 namespace Rector\Tests\Php83\Rector\BooleanAnd\JsonValidateRector\Fixture;
 
-if (json_validate($json)){
+if (json_validate($json, true, 512)){
     echo 1;
 }
 ?>

rules/Php83/Rector/BooleanAnd/JsonValidateRector.php

@@ -11,18 +11,13 @@
 use PhpParser\Node\Expr\BinaryOp\NotIdentical;
 use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\Node\Expr\FuncCall;
-use PhpParser\Node\Identifier;
 use PhpParser\Node\Name;
 use PHPStan\Analyser\Scope;
-use PHPStan\Reflection\Native\NativeFunctionReflection;
-use Rector\NodeAnalyzer\ArgsAnalyzer;
 use Rector\NodeManipulator\BinaryOpManipulator;
 use Rector\NodeTypeResolver\Node\AttributeKey;
-use Rector\NodeTypeResolver\PHPStan\ParametersAcceptorSelectorVariantsWrapper;
 use Rector\Php71\ValueObject\TwoNodeMatch;
 use Rector\PhpParser\Node\Value\ValueResolver;
 use Rector\Rector\AbstractRector;
-use Rector\Reflection\ReflectionResolver;
 use Rector\ValueObject\PhpVersionFeature;
 use Rector\ValueObject\PolyfillPackage;
 use Rector\VersionBonding\Contract\MinPhpVersionInterface;
@@ -41,8 +36,6 @@ final class JsonValidateRector extends AbstractRector implements MinPhpVersionIn
 
     public function __construct(
         private readonly BinaryOpManipulator $binaryOpManipulator,
-        private readonly ReflectionResolver $reflectionResolver,
-        private readonly ArgsAnalyzer $argsAnalyzer,
         private ValueResolver $valueResolver,
     ) {
     }
@@ -102,15 +95,12 @@ public function refactor(Node $node): ?Node
         }
 
         $args = $funcCall->getArgs();
-        $positions = $this->argsAnalyzer->hasNamedArg($args)
-            ? $this->resolveNamedPositions($args)
-            : $this->resolveOriginalPositions($funcCall, $scope);
 
-        if ($positions === []) {
+        if ($args === []) {
             return null;
         }
 
-        if (! $this->validateArgs($args, $positions)) {
+        if (! $this->validateArgs($funcCall)) {
             return null;
         }
         $funcCall->name = new Name('json_validate');
@@ -164,81 +154,25 @@ public function matchJsonValidateArg(BooleanAnd $booleanAnd): ?FuncCall
         return $funcCall;
     }
 
-    /**
-     * @param Arg[] $args
-     * @param int[]|string[] $positions
-     */
-    protected function validateArgs(array $args, array $positions): bool
+    protected function validateArgs(FuncCall $funcCall): bool
     {
-        foreach ($positions as $position) {
-            $arg = $args[$position] ?? '';
-            if ($arg instanceof Arg && $arg->name instanceof Identifier && $arg->name->toString() === 'flags') {
-                $flags = $this->valueResolver->getValue($arg);
-                if ($flags !== JSON_INVALID_UTF8_IGNORE) {
-                    return false;
-                }
-            }
-            if ($arg instanceof Arg && $arg->name instanceof Identifier && $arg->name->toString() === 'depth') {
-                $depth = $this->valueResolver->getValue($arg);
-                if ($depth <= 0) {
-                    return false;
-                }
-                if ($depth > self::JSON_MAX_DEPTH) {
-                    return false;
-                }
-            }
-        }
-
-        return true;
-    }
-
-    /**
-     * @param Arg[] $args
-     * @return int[]|string[]
-     */
-    private function resolveNamedPositions(array $args): array
-    {
-        $positions = [];
-
-        foreach ($args as $position => $arg) {
-            if (! $arg->name instanceof Identifier) {
-                continue;
-            }
+        $depth = $funcCall->getArg('depth', 2);
+        $flags = $funcCall->getArg('flags', 3);
 
-            if (! $this->isNames($arg->name, self::ARG_NAMES)) {
-                continue;
+        if ($flags instanceof Arg) {
+            $flagsValue = $this->valueResolver->getValue($flags);
+            if ($flagsValue !== JSON_INVALID_UTF8_IGNORE) {
+                return false;
             }
-
-            $positions[] = $position;
         }
 
-        return $positions;
-    }
-
-    /**
-     * @return int[]|string[]
-     */
-    private function resolveOriginalPositions(FuncCall $funcCall, Scope $scope): array
-    {
-        $functionReflection = $this->reflectionResolver->resolveFunctionLikeReflectionFromCall($funcCall);
-        if (! $functionReflection instanceof NativeFunctionReflection) {
-            return [];
-        }
-
-        $parametersAcceptor = ParametersAcceptorSelectorVariantsWrapper::select(
-            $functionReflection,
-            $funcCall,
-            $scope
-        );
-
-        $positions = [];
-
-        foreach ($parametersAcceptor->getParameters() as $position => $parameterReflection) {
-            if (in_array($parameterReflection->getName(), self::ARG_NAMES, true)) {
-                $positions[] = $position;
+        if ($depth instanceof Arg) {
+            $depthValue = $this->valueResolver->getValue($depth);
+            if ($depthValue <= 0 || $depthValue > self::JSON_MAX_DEPTH) {
+                return false;
             }
         }
 
-        return $positions;
+        return true;
     }
 }

tests/bootstrap.php

@@ -7,7 +7,11 @@
 require_once __DIR__ . '/../vendor/autoload.php';
 
 // silent deprecations, since we test them
-error_reporting(E_ALL ^ E_DEPRECATED);
+// error_reporting(E_ALL ^ E_DEPRECATED);
+error_reporting(E_ALL);
+set_error_handler(function (int $severity, string $message, string $file, int $line): bool {
+    throw new \ErrorException($message, 0, $severity, $file, $line);
+});
 
 // performance boost
 gc_disable();